-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ICS3 connection handshake protocol (message processing logic) #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romac
reviewed
Aug 3, 2020
romac
reviewed
Aug 3, 2020
adizere
changed the title
WIP: ICS3 connection handshake message processing logic (core & context)
ICS3 connection handshake protocol (message processing logic)
Aug 7, 2020
Split the protocol into per message submodules Extract verification in separate submodule Other changes as per ADR003
Codecov Report
@@ Coverage Diff @@
## master informalsystems/hermes#188 +/- ##
=========================================
+ Coverage 13.6% 34.8% +21.1%
=========================================
Files 69 78 +9
Lines 3752 5038 +1286
Branches 1374 1714 +340
=========================================
+ Hits 513 1755 +1242
- Misses 2618 3076 +458
+ Partials 621 207 -414
Continue to review full report at Codecov.
|
Started TryFromRaw for connection messages. Some work on commitment prefix, path, root.
12 tasks
adizere
commented
Sep 3, 2020
romac
requested changes
Sep 3, 2020
romac
approved these changes
Sep 3, 2020
hu55a1n1
pushed a commit
to hu55a1n1/hermes
that referenced
this pull request
Sep 13, 2022
…logic) (informalsystems#188) * First processing logic for ICS 03 (#160). * Fix for temporary pick_version(). * First attempt at the process_try_msg function. * Sketch for proof verification in process_try_msg. Removed Connection* traits. * Added logic for the Try message. * Logic for processing ICS3 confirm msg. Cosmetic improvements * Adapting code to new architecture based on contexts. * Refactored, new terminology, added events. * WIP: Adding tests * Higher-level interface for the context. * One chunk of proof verification is done * Implementation of ics3 verify_proofs done. * Addressing Romain's concerns. * Tests for conn open init message processing. * Fixes for integration tests: PartialEq for identifiers. * More changes cf adr003 and code reorg * Move info to new context and context_mock modules * migrate conn-open-init to new infra * Refine client and connection mock context * Fix conn_open_try handler * Create new mock_client * remove mocks.rs * Add global chain context * Uncomment tests * Cleanup * Started to fill client verification functions. Started TryFromRaw for connection messages. Some work on commitment prefix, path, root. * Add try_from for connection messages and remove new() * Add test for try dispatch * Some changes to mock context setup * Some cleanup * Review comments * Mark mocks as `#[cfg(test)] * Fix clippy warnings * Remove use of clone in a Debug impl Co-authored-by: Anca Zamfir <[email protected]> Co-authored-by: Romain Ruetschi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: cosmos/ibc-rs#127
Closes: cosmos/ibc-rs#119(already closed)Ready for review.
The most significant part left open is adding more unit tests.
Also, in case you're wondering, the
PartialEq
additions in the last commit are necessary to fix integration tests (see failures here, filerelayer-cli/tests/integration.rs
).Description
For contributor use:
docs/
) and code commentsFiles changed
in the Github PR explorer