ICS03 - Connection handshake #127
Assignees
Comments
3 tasks
adizere
referenced
this issue
in informalsystems/hermes
Jul 29, 2020
6 tasks
12 tasks
adizere
referenced
this issue
in informalsystems/hermes
Sep 3, 2020
…logic) (#188) * First processing logic for ICS 03 (#160). * Fix for temporary pick_version(). * First attempt at the process_try_msg function. * Sketch for proof verification in process_try_msg. Removed Connection* traits. * Added logic for the Try message. * Logic for processing ICS3 confirm msg. Cosmetic improvements * Adapting code to new architecture based on contexts. * Refactored, new terminology, added events. * WIP: Adding tests * Higher-level interface for the context. * One chunk of proof verification is done * Implementation of ics3 verify_proofs done. * Addressing Romain's concerns. * Tests for conn open init message processing. * Fixes for integration tests: PartialEq for identifiers. * More changes cf adr003 and code reorg * Move info to new context and context_mock modules * migrate conn-open-init to new infra * Refine client and connection mock context * Fix conn_open_try handler * Create new mock_client * remove mocks.rs * Add global chain context * Uncomment tests * Cleanup * Started to fill client verification functions. Started TryFromRaw for connection messages. Some work on commitment prefix, path, root. * Add try_from for connection messages and remove new() * Add test for try dispatch * Some changes to mock context setup * Some cleanup * Review comments * Mark mocks as `#[cfg(test)] * Fix clippy warnings * Remove use of clone in a Debug impl Co-authored-by: Anca Zamfir <[email protected]> Co-authored-by: Romain Ruetschi <[email protected]>
hu55a1n1
referenced
this issue
in hu55a1n1/hermes
Sep 13, 2022
…logic) (informalsystems#188) * First processing logic for ICS 03 (#160). * Fix for temporary pick_version(). * First attempt at the process_try_msg function. * Sketch for proof verification in process_try_msg. Removed Connection* traits. * Added logic for the Try message. * Logic for processing ICS3 confirm msg. Cosmetic improvements * Adapting code to new architecture based on contexts. * Refactored, new terminology, added events. * WIP: Adding tests * Higher-level interface for the context. * One chunk of proof verification is done * Implementation of ics3 verify_proofs done. * Addressing Romain's concerns. * Tests for conn open init message processing. * Fixes for integration tests: PartialEq for identifiers. * More changes cf adr003 and code reorg * Move info to new context and context_mock modules * migrate conn-open-init to new infra * Refine client and connection mock context * Fix conn_open_try handler * Create new mock_client * remove mocks.rs * Add global chain context * Uncomment tests * Cleanup * Started to fill client verification functions. Started TryFromRaw for connection messages. Some work on commitment prefix, path, root. * Add try_from for connection messages and remove new() * Add test for try dispatch * Some changes to mock context setup * Some cleanup * Review comments * Mark mocks as `#[cfg(test)] * Fix clippy warnings * Remove use of clone in a Debug impl Co-authored-by: Anca Zamfir <[email protected]> Co-authored-by: Romain Ruetschi <[email protected]>
shuoer86
pushed a commit
to shuoer86/ibc-rs
that referenced
this issue
Nov 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Re informalsystems/hermes#119. We already have the ICS03 message types, so we should build out the logic for processing them - ie. the connection handshake.
I think this can start with an abstract KV-Store and Client, but it should ultimately leverage informalsystems/hermes#158.
We should be able to test it simply by running two instances of the connection handlers against each other, potentially even without the machinery of informalsystems/hermes#158.
The text was updated successfully, but these errors were encountered: