Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ICS3 connection handshake protocol (message processing logic) #188
ICS3 connection handshake protocol (message processing logic) #188
Changes from 36 commits
9f42758
cb49076
d45dbeb
faeebcd
7c66d9f
c799254
84d26bc
645659f
eb7d56f
8f9e4d4
3c5fa93
b03fbd3
9a4bf0f
c345037
1c5bf1d
e0bd419
7b927f1
f1b3d26
c63616b
118746f
06140d0
e72333a
ee621a5
18eaffa
9e29bd9
cfba83b
df6c2b4
6b56737
17deff1
a039783
d68daed
f563534
98738cd
a4b0068
c0fbbc8
a01c667
ee1fd7e
fd55dee
0fc9e3a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this variant is only used in tests, we should annotate this branch/case with
#[cfg(test)]
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this variant is only used in tests, we should annotate this branch/case with
#[cfg(test)]
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this variant is only used in tests, we should annotate this branch/case with
#[cfg(test)]
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this variant is only used in tests, we should annotate it with
#[cfg(test)]
.