Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(models): permanently enabled uint64 support #15776

Merged
merged 1 commit into from
Dec 10, 2019
Merged

refactor(models): permanently enabled uint64 support #15776

merged 1 commit into from
Dec 10, 2019

Conversation

ayang64
Copy link
Contributor

@ayang64 ayang64 commented Nov 5, 2019

  • Remove all instances of EnableUintSupport()

  • Remove all instances of enableUint64Support

Ultimately this unconditionally enables uint64 support.

Closes #15711

Describe your proposed changes here.

@e-dard e-dard requested review from jsternberg and benbjohnson and removed request for benbjohnson December 3, 2019 11:08
Copy link
Contributor

@e-dard e-dard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@e-dard e-dard changed the title chore(models) Permanently enabled uint64 support (#15711) chore(models): permanently enabled uint64 support Dec 3, 2019
@e-dard
Copy link
Contributor

e-dard commented Dec 3, 2019

@ayang64 actually, could you change your commit message to:

refactor: permanently enable uint64 support

@e-dard e-dard changed the title chore(models): permanently enabled uint64 support refactor(models): permanently enabled uint64 support Dec 3, 2019
* Remove all instances of EnableUintSupport()

* Remove all instances of enableUint64Support

Closes #15711
@ayang64 ayang64 merged commit 0681b41 into influxdata:master Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make uint64 support permanently enabled
3 participants