Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(models): permanently enabled uint64 support #15776

Merged
merged 1 commit into from
Dec 10, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 0 additions & 24 deletions models/points.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,16 +18,6 @@ import (
"github.com/influxdata/influxdb/pkg/escape"
)

// FIXME(edd): this temporarily enables uint64 support. It should be enabled by
// default in 2.0. Therefore we need to pay down all the technical debt of cleaning
// up all the conditionals within this package.
//
// This issue tracks the cleanup work:
// https://github.com/influxdata/influxdb/issues/15711
func init() {
EnableUintSupport()
}

// Values used to store the field key and measurement name as special internal tags.
const (
FieldKeyTagKey = "\xff"
Expand Down Expand Up @@ -76,16 +66,6 @@ const (
MaxKeyLength = 65535
)

// enableUint64Support will enable uint64 support if set to true.
var enableUint64Support = false

// EnableUintSupport manually enables uint support for the point parser.
// This function will be removed in the future and only exists for unit tests during the
// transition.
func EnableUintSupport() {
enableUint64Support = true
}

// Point defines the values that will be written to the database.
type Point interface {
// Name return the measurement name for the point.
Expand Down Expand Up @@ -1075,10 +1055,6 @@ func scanNumber(buf []byte, i int) (int, error) {
}
}
} else if isUnsigned {
// Return an error if uint64 support has not been enabled.
if !enableUint64Support {
return i, ErrInvalidNumber
}
// Make sure the last char is a 'u' for unsigned
if buf[i-1] != 'u' {
return i, ErrInvalidNumber
Expand Down
7 changes: 0 additions & 7 deletions models/uint_support.go

This file was deleted.