Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make uint64 support permanently enabled #15711

Closed
e-dard opened this issue Nov 1, 2019 · 3 comments · Fixed by #15776
Closed

Make uint64 support permanently enabled #15711

e-dard opened this issue Nov 1, 2019 · 3 comments · Fixed by #15776
Assignees
Labels
area/writes difficulty/low Resolving this issue should take a day or two. kind/tech-debt Needs cleanup, will make the developer experience better

Comments

@e-dard
Copy link
Contributor

e-dard commented Nov 1, 2019

In 2.0 we should have full uint64 support enabled. This issue is to track cleaning up the technical debt left from when we had uint64 behind a build flag.

Start by removing this:

var enableUint64Support = false

And go from there...

By the end, there should be no option to enable/disable uint64 support throughout the codebase.

@e-dard e-dard added area/writes good first issue kind/tech-debt Needs cleanup, will make the developer experience better difficulty/low Resolving this issue should take a day or two. labels Nov 1, 2019
@nwneisen
Copy link
Contributor

nwneisen commented Dec 2, 2019

I'm interested in working on this but it looks like @ayang64 has already made the change. Is this PR just needing a signed CLA and verification that tests are passing?

@e-dard
Copy link
Contributor Author

e-dard commented Dec 3, 2019

@nwneisen yep, Ayan took that one. It's great to see interest in contributing from the community. There is another issue here labelled as a good starter here: #15571

What sorts of things are you interested in within the code-base?

@nwneisen
Copy link
Contributor

nwneisen commented Dec 3, 2019

@e-dard I had started taking a look at #15571 after commenting.

At the moment, I'm interested in working in areas that would make me better at using InfluxDB. I answered some questions on stack overflow for Telegraf and there were some for InfluxDB that I thought I would try to answer also.

I was going to take a look at issues tagged with difficulty/low next. If there are any areas you view as higher priority, let me know and I will go for them first.

@8none1 8none1 assigned 8none1 and ayang64 and unassigned 8none1 Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/writes difficulty/low Resolving this issue should take a day or two. kind/tech-debt Needs cleanup, will make the developer experience better
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants