Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable uint64 support #15712

Merged
merged 1 commit into from
Nov 1, 2019
Merged

fix: enable uint64 support #15712

merged 1 commit into from
Nov 1, 2019

Conversation

e-dard
Copy link
Contributor

@e-dard e-dard commented Nov 1, 2019

This PR enables uint64 support in InfluxDB. This means that you can write unsigned integers into the database. To differentiate between unsigned integer values and signed integer values, use the u suffix.

Example:

influx write -o edd -b edd  "cpu,region=west balance=-232i,space=23432u

Where balance is a regular signed integer, and space is an unsigned integer.

Within the TSM storage engine both signed and unsigned integers are compressed in the same way. You cannot mix signed and unsigned integers within the same series, e.g., you cannot do this:

influx write -o edd -b edd  "cpu,region=west space=23432u
influx write -o edd -b edd  "cpu,region=west space=100i

The approach here is temporary. We should make this change permanent by removing all the code that allows uint64 to be disabled. #15711 tracks that work

Copy link
Contributor

@jsternberg jsternberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, this makes sense. The only reason it is not enabled automatically is because we wanted to add uint64 support to the rest of the 1.x products before enabling it in 1.x. Since this only applies to 2.0, it makes sense to enable the support by default.

@e-dard e-dard merged commit 2ccd93d into master Nov 1, 2019
@e-dard e-dard deleted the er-uint64 branch November 1, 2019 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants