-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rendergraph] Refactoring, part 1 of 2 #524
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IAmNotHanni
changed the title
Small refactoring of rendergraph
Refactoring of rendergraph
Mar 8, 2023
IAmNotHanni
force-pushed
the
hanni/rendergraph_refactoring
branch
2 times, most recently
from
March 12, 2023 14:22
b0a2c97
to
0efd073
Compare
IAmNotHanni
changed the title
Refactoring of rendergraph
[rendergraph] Refactoring, part 1 of 2
Mar 16, 2023
IAmNotHanni
force-pushed
the
hanni/rendergraph_refactoring
branch
from
March 18, 2023 20:32
0efd073
to
898db30
Compare
I am working on a new rendergraph implementation currently, so I converted it back to a draft. We might not need all of this. |
I will close this because it will come back as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Closes #277
uses_shaders
push_constant_range
template methodTextureResource
and removeset_format
methodVkPipelineLayout
VkRenderPass
(This will go away once we have dynamic rendering)Add renderpass builder(Renderpasses will be removed anyways once we support dynamic rendering: Implement support for dynamic rendering #438)VkSampler
Image
RAII wrapper class and use it in rendergraphMeshBuffer
classmsaa_target.hpp
fileOutlook: Refactoring, part 2