Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement basic SPIR-V reflection #418

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

yeetari
Copy link
Member

@yeetari yeetari commented Jul 17, 2021

This PR introduces SPIR-V reflection to parse the execution stage and push constant size from each shader. We can take this further and extract more things like descriptor set layouts in the future.

@IAmNotHanni
Copy link
Member

Maybe change title to "refactoring" or "improvements", otherwise people might think it's about actual reflection in rendering :D

@yeetari yeetari changed the title Shader reflection Implement baisc SPIR-V reflection Jul 17, 2021
@yeetari yeetari changed the title Implement baisc SPIR-V reflection Implement basic SPIR-V reflection Jul 17, 2021
This isn't that useful, and I'm not even sure if anything other than
"main" is allowed in GLSL.
@IAmNotHanni
Copy link
Member

I think I will take over this pull request and implement it based on spirv-cross. I mentioned on Discord already that I don't see much sense in writing the shader reflection code ourselves, even though spirv-cross might be more massive of a library than we need :) Also, it looks like it's being tested and maintained continuously.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants