Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Galaxy Fold Pagination Overflow (resolves #384) #385

Merged

Conversation

TeddTech
Copy link
Contributor

@TeddTech TeddTech commented Sep 8, 2020

  • This pull request has been linted by running npm run lint without errors
  • This pull request has been tested by running npm run start and reviewing affected routes
  • This pull request has been built by running npm run build without errors
  • This isn't a duplicate of an existing pull request

Description

This PR fixes the pagination overflow on the Galaxy Fold screen.

Steps to test

  1. Go to the Continuing Our work During Covid-19 article on the We Count development site
  2. Inspect page using Galaxy fold view
  3. Scroll down to the pagination component

Expected behavior:
The pagination component should no longer overflow on the Galaxy Fold screen.

Additional information

N/A

Related issues

closes #384 and closes #386

@TeddTech TeddTech requested a review from cindyli September 8, 2020 22:40
@TeddTech TeddTech self-assigned this Sep 8, 2020
@TeddTech TeddTech added the bug Something isn't working label Sep 8, 2020
@cindyli cindyli merged commit f4a02ca into inclusive-design:dev Sep 9, 2020
@cindyli
Copy link
Contributor

cindyli commented Sep 9, 2020

Thanks for the excellent fix, @TeddTech. This pull request also fixed the issue #386.

@TeddTech TeddTech deleted the galaxy-fold-pagination-overflow branch September 18, 2020 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pagination Text Overflow in Mobile View with Galaxy Fold Pagination Overflow
2 participants