Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Galaxy Fold Pagination Overflow #384

Closed
TeddTech opened this issue Sep 8, 2020 · 0 comments · Fixed by #385
Closed

Galaxy Fold Pagination Overflow #384

TeddTech opened this issue Sep 8, 2020 · 0 comments · Fixed by #385
Assignees
@TeddTech
Labels
bug Something isn't working
Milestone
2.3.0

Comments

@TeddTech
Copy link
Contributor

TeddTech commented Sep 8, 2020

Describe the bug

Pagination component overflows for galaxy fold screen size.

To Reproduce

Steps to reproduce the behavior:

  1. Go to the Continuing Our work During Covid-19 article on the We Count development site
  2. Inspect page using Galaxy fold view
  3. Scroll down to the pagination component
  4. See error (the pagination component is overflowing)

Expected behavior

The pagination component should not overflow

Screenshots

Screen Shot 2020-09-04 at 9 57 34 AM

Screen Shot 2020-09-04 at 9 58 51 AM

Additional context

N/A
@TeddTech TeddTech added the bug Something isn't working label Sep 8, 2020
@TeddTech TeddTech self-assigned this Sep 8, 2020
@TeddTech TeddTech mentioned this issue Sep 8, 2020
Merged
4 tasks
cindyli pushed a commit that referenced this issue Sep 9, 2020
@TeddTech
Fix Galaxy Fold Pagination Overflow (resolves #384) (#385)
f4a02ca 
* fix: applied inline flex to tag fiter label span

* fix: added pagination styling for galazy screen

* fix: decreased pagination font size in mobile view

* fix: add different pagination line height for desktop view

* fix: made left and right margin value auto for desktop
@cindyli cindyli added this to the WeCount 2.3.0 milestone Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TeddTech TeddTech

Labels
bug Something isn't working
Projects
None yet
Milestone
2.3.0
Development

Successfully merging a pull request may close this issue.

Fix Galaxy Fold Pagination Overflow (resolves #384) TeddTech/wecount.inclusivedesign.ca
2 participants
@cindyli @TeddTech