Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Galaxy Fold Pagination Overflow (resolves #384) #385

Merged
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
f2245c4
fix: applied inline flex to tag fiter label span
TeddTech Jul 20, 2020
d440600
Merge remote-tracking branch 'upstream/dev' into dev
TeddTech Jul 22, 2020
380a982
Merge remote-tracking branch 'upstream/dev' into dev
TeddTech Jul 23, 2020
4e6e219
Merge remote-tracking branch 'upstream/dev' into dev
TeddTech Jul 24, 2020
e4ca6f0
Merge remote-tracking branch 'upstream/dev' into dev
TeddTech Jul 24, 2020
b4f141d
Merge remote-tracking branch 'upstream/dev' into dev
TeddTech Jul 24, 2020
2dbf9b2
Merge remote-tracking branch 'upstream/dev' into dev
TeddTech Jul 30, 2020
6efe495
Merge remote-tracking branch 'upstream/dev' into dev
TeddTech Jul 31, 2020
d21a1ef
Merge remote-tracking branch 'upstream/dev' into dev
TeddTech Jul 31, 2020
d20e814
Merge remote-tracking branch 'upstream/dev' into dev
TeddTech Aug 5, 2020
af13880
Merge remote-tracking branch 'upstream/dev' into dev
TeddTech Aug 6, 2020
a1932d6
Merge remote-tracking branch 'upstream/dev' into dev
TeddTech Aug 7, 2020
ee51c33
Merge remote-tracking branch 'upstream/dev' into dev
TeddTech Aug 7, 2020
3a870cf
Merge remote-tracking branch 'upstream/dev' into dev
TeddTech Aug 26, 2020
f51c1ea
Merge remote-tracking branch 'upstream/dev' into dev
TeddTech Sep 1, 2020
2977295
Merge remote-tracking branch 'upstream/dev' into dev
TeddTech Sep 3, 2020
bdf6abc
fix: added pagination styling for galazy screen
TeddTech Sep 8, 2020
d85ae8b
fix: decreased pagination font size in mobile view
TeddTech Sep 8, 2020
8a07833
fix: add different pagination line height for desktop view
TeddTech Sep 9, 2020
7666ab4
fix: made left and right margin value auto for desktop
TeddTech Sep 9, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 25 additions & 3 deletions src/scss/components/_pagination.scss
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
.pagination {
display: block;
line-height: rem(32);
line-height: rem(38);
list-style: none;
margin-left: -10%;
margin-right: -10%;
margin-top: rem(27);
padding: 0;
text-align: center;
Expand Down Expand Up @@ -30,7 +32,7 @@
border-radius: 100%;
box-shadow: 0 0 0 rem(2) $blue-alt-light inset;
float: left;
font-size: rem(24);
font-size: rem(18);
font-weight: 400;
height: rem(45);
line-height: rem(45);
Expand Down Expand Up @@ -63,7 +65,7 @@

span {
color: $blue-alt;
font-size: rem(24);
font-size: rem(18);
}
}

Expand Down Expand Up @@ -126,6 +128,9 @@

@include breakpoint-up(lg) {
.pagination {
line-height: rem(35);
margin-left: auto;
margin-right: auto;
margin-top: rem(62);

.previous,
Expand All @@ -135,6 +140,10 @@

.pagination-ellipsis {
margin: rem(4) rem(0);

span {
font-size: rem(24);
}
}

li.hide-on-mobile {
Expand All @@ -150,10 +159,23 @@
}

.pagination-link {
font-size: rem(24);
height: rem(53);
line-height: rem(53);
margin: 0 rem(13);
width: rem(53);
}

.pagination-next,
.pagination-previous {
line-height: rem(40);
}
}
}

// This media query breakpoint comes the width of the Galaxy Fold screen.
@include breakpoint-down(xs) {
.pagination .pagination-link {
margin: rem(10) rem(3);
}
}