Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non-trainable recommender may be invoked even though inheritable predictions exist #4990

Closed
reckart opened this issue Aug 14, 2024 · 0 comments
Closed

Non-trainable recommender may be invoked even though inheritable predictions exist #4990

reckart opened this issue Aug 14, 2024 · 0 comments
Assignees
@reckart
Labels
🐛 Bug Something isn't working Module: Recommender
Milestone
33.5

Comments

@reckart
Copy link
Member

reckart commented Aug 14, 2024

Describe the bug
Non-trainable recommender may be invoked even though inheritable predictions exist.

To Reproduce
Steps to reproduce the behavior:

  1. Open a document in a project with a slightly slow recommender
  2. While the recommender is still predicting, create an annotation
  3. Notice that when the first prediction round is done, a second one is triggered and no predictions are inherited from the first one

Expected behavior
The result from the first prediction round should be inherited since the recommender is not trainable.

Please complete the following information:

  • Version and build ID: 33.4
@reckart reckart added 🐛 Bug Something isn't working Module: Recommender labels Aug 14, 2024
@reckart reckart added this to the 33.5 milestone Aug 14, 2024
@reckart reckart self-assigned this Aug 14, 2024
@reckart reckart added this to Kanban Aug 14, 2024
@github-project-automation github-project-automation bot moved this to 🔖 To do in Kanban Aug 14, 2024
reckart added a commit that referenced this issue Aug 14, 2024
@reckart
#4990 - Non-trainable recommender may be invoked even though inherita…
5798013 
…ble predictions exist

- The inheritable annotations may be in the incoming predictions and not in the active predictions, so look at incoming first, if none are there, then look in active.
reckart added a commit that referenced this issue Aug 14, 2024
@reckart
Merge pull request #4991 from inception-project/bugfix/4990-Non-train…
b25a25c 
…able-recommender-may-be-invoked-even-though-inheritable-predictions-exist

#4990 - Non-trainable recommender may be invoked even though inheritable predictions exist
@reckart reckart closed this as completed Aug 14, 2024
@github-project-automation github-project-automation bot moved this from 🔖 To do to 🍹 Done in Kanban Aug 14, 2024
reckart added a commit that referenced this issue Aug 15, 2024
@reckart
Merge branch 'release/33.x'
e70c002 
* release/33.x:
  #4992 - Cannot access document panel anymore if a source document has gone missing
  #4990 - Non-trainable recommender may be invoked even though inheritable predictions exist
  #4988 - UIMA type system import cannot deal with cross-layer relations
  #4984 - Warnings drop-up in the footer no longer opens

% Conflicts:
%	inception/inception-api-annotation/src/main/java/de/tudarmstadt/ukp/inception/annotation/feature/link/LinkFeatureSupport.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reckart reckart

Labels
🐛 Bug Something isn't working Module: Recommender
Projects
Kanban
Archived in project
Milestone
33.5
Development

No branches or pull requests
1 participant
@reckart