Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4990 - Non-trainable recommender may be invoked even though inheritable predictions exist #4991

Conversation

reckart
Copy link
Member

@reckart reckart commented Aug 14, 2024

What's in the PR

  • The inheritable annotations may be in the incoming predictions and not in the active predictions, so look at incoming first, if none are there, then look in active.

How to test manually

  • See issue description

Automatic testing

  • PR includes unit tests

Documentation

  • PR updates documentation

…ble predictions exist

- The inheritable annotations may be in the incoming predictions and not in the active predictions, so look at incoming first, if none are there, then look in active.
@reckart reckart added 🐛Bug Something isn't working Module: Recommender labels Aug 14, 2024
@reckart reckart added this to the 33.5 milestone Aug 14, 2024
@reckart reckart self-assigned this Aug 14, 2024
@reckart reckart merged commit b25a25c into release/33.x Aug 14, 2024
3 checks passed
@reckart reckart deleted the bugfix/4990-Non-trainable-recommender-may-be-invoked-even-though-inheritable-predictions-exist branch August 14, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛Bug Something isn't working Module: Recommender
Projects
Status: 🍹 Done
Development

Successfully merging this pull request may close these issues.

1 participant