#4990 - Non-trainable recommender may be invoked even though inherita…

…ble predictions exist

- The inheritable annotations may be in the incoming predictions and not in the active predictions, so look at incoming first, if none are there, then look in active.

inception/inception-recommendation/src/main/java/de/tudarmstadt/ukp/inception/recommendation/tasks/PredictionTask.java

@@ -213,8 +213,7 @@ private Predictions generatePredictionsOnAllDocuments(List<SourceDocument> aDocu
         var monitor = getMonitor();
         var sessionOwner = getSessionOwner();
         var project = getProject();
-        var activePredictions = isolated ? null
-                : recommendationService.getPredictions(sessionOwner, project);
+        var activePredictions = getPredecessorPredictions(sessionOwner, project);
         var incomingPredictions = activePredictions != null ? new Predictions(activePredictions)
                 : new Predictions(sessionOwner, dataOwner, project);
 
@@ -260,14 +259,14 @@ private Predictions generatePredictionsOnSingleDocument(SourceDocument aCurrentD
     {
         var sessionOwner = getSessionOwner();
         var project = getProject();
-        var activePredictions = isolated ? null
-                : recommendationService.getPredictions(sessionOwner, project);
-        var incomingPredictions = activePredictions != null ? new Predictions(activePredictions)
+        var predecessorPredictions = getPredecessorPredictions(sessionOwner, project);
+        var incomingPredictions = predecessorPredictions != null
+                ? new Predictions(predecessorPredictions)
                 : new Predictions(sessionOwner, dataOwner, project);
 
         aMonitor.setMaxProgress(1);
 
-        if (activePredictions != null) {
+        if (predecessorPredictions != null) {
             // Limit prediction to a single document and inherit the rest
             var documentsToInheritSuggestionsFor = aDocuments.stream() //
                     .filter(d -> !d.equals(currentDocument)) //
@@ -276,7 +275,7 @@ private Predictions generatePredictionsOnSingleDocument(SourceDocument aCurrentD
             logPredictionStartedForOneDocumentWithInheritance(documentsToInheritSuggestionsFor);
 
             for (var document : documentsToInheritSuggestionsFor) {
-                inheritSuggestionsAtDocumentLevel(project, document, activePredictions,
+                inheritSuggestionsAtDocumentLevel(project, document, predecessorPredictions,
                         incomingPredictions);
             }
         }
@@ -287,8 +286,8 @@ private Predictions generatePredictionsOnSingleDocument(SourceDocument aCurrentD
         try (var casHolder = new PredictionCasHolder()) {
 
             final CAS predictionCas = casHolder.cas;
-            applyAllRecommendersToDocument(activePredictions, incomingPredictions, predictionCas,
-                    aCurrentDocument, predictionBegin, predictionEnd);
+            applyAllRecommendersToDocument(predecessorPredictions, incomingPredictions,
+                    predictionCas, aCurrentDocument, predictionBegin, predictionEnd);
         }
         catch (ResourceInitializationException e) {
             logErrorCreationPredictionCas(incomingPredictions);
@@ -299,6 +298,21 @@ private Predictions generatePredictionsOnSingleDocument(SourceDocument aCurrentD
         return incomingPredictions;
     }
 
+    private Predictions getPredecessorPredictions(User sessionOwner, Project project)
+    {
+        if (isolated) {
+            return null;
+        }
+
+        var incomingPredictions = recommendationService.getIncomingPredictions(sessionOwner,
+                project);
+        if (incomingPredictions != null) {
+            return incomingPredictions;
+        }
+
+        return recommendationService.getPredictions(sessionOwner, project);
+    }
+
     /**
      * @param aPredictions
      *            the predictions to populate