feat: integrate with v0.52.x (3/n) #4432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
component:ci
12 tasks
12 tasks
julienrbrt
requested review from
ilgooz,
salmad3,
toschdev,
jeronimoalbi and
Pantani
as code owners
|
R4R and to be merged, once cosmos/cosmos-sdk#22721 is merged and backported, |
|
Once merged, I'll check the sdk.Context removal. Then onto v2 (where possibly let's scaffold tx validators) :) |
Merged
12 tasks
Pantani
reviewed
Dec 4, 2024
ignite/templates/typed/map/files/simapp/x/{{moduleName}}/simulation/{{typeName}}.go.plush
Show resolved
Hide resolved
Looks like after SDK bump it shown some issue in simulation wiring. Will fix ASAP |
Hi! I am getting an panic when running a full simulation on an empty scaffolded project via ignite 0.29 (nightly). Is this a related issue? Trace: goos: darwin
goarch: arm64
pkg: kepler/app
cpu: Apple M4 Pro
BenchmarkFullAppSimulation
simulate.go:110: 2:43PM INF Starting SimulateFromSeed with randomness seed=1
panic: unable to resolve type URL /cosmos.vesting.v1beta1.DelayedVestingAccount
goroutine 41 [running]:
github.com/cosmos/cosmos-sdk/codec.(*ProtoCodec).MustMarshalJSON(0x98?, {0x1031187e0?, 0x140009aa040?})
/Users/devdammit/.gvm/pkgsets/go1.23.3/global/pkg/mod/github.com/cosmos/[email protected]/codec/proto_codec.go:159 +0x48
github.com/cosmos/cosmos-sdk/x/auth/simulation.RandomizedGenState(0x1400145e9c0, 0x1030f0810)
/Users/devdammit/.gvm/pkgsets/go1.23.3/global/pkg/mod/github.com/cosmos/[email protected]/x/auth/simulation/genesis.go:114 +0x288
github.com/cosmos/cosmos-sdk/x/auth.AppModule.GenerateGenesisState(...)
/Users/devdammit/.gvm/pkgsets/go1.23.3/global/pkg/mod/github.com/cosmos/[email protected]/x/auth/module.go:189
github.com/cosmos/cosmos-sdk/testutil/sims.generateGenesisStates(...)
/Users/devdammit/.gvm/pkgsets/go1.23.3/global/pkg/mod/github.com/cosmos/[email protected]/testutil/sims/state_helpers.go:273
github.com/cosmos/cosmos-sdk/testutil/sims.AppStateRandomizedFn({0x14001d9fa00, 0x5, 0x81b71b66c2?}, 0x1400205ca20, {0x103131a90, 0x140002ac8e0}, {0x14002080000, 0x99f, 0x99f}, {0x24093de1afa?, ...}, ...)
/Users/devdammit/.gvm/pkgsets/go1.23.3/global/pkg/mod/github.com/cosmos/[email protected]/testutil/sims/state_helpers.go:203 +0x26c
kepler/app.setupStateFactory.AppStateFn.func1(0x1400205ca20, {0x14002080000, _, _}, {{0x0, 0x0}, {0x0, 0x0}, {0x0, 0x0}, ...})
/Users/devdammit/.gvm/pkgsets/go1.23.3/global/pkg/mod/github.com/cosmos/[email protected]/testutil/sims/state_helpers.go:89 +0x21c
github.com/cosmos/cosmos-sdk/x/simulation.initChain(0x1400205ca20, {0x3fe359608841ff3f, _, _, {_, _, _}, {_, _}, {_, ...}}, ...)
/Users/devdammit/.gvm/pkgsets/go1.23.3/global/pkg/mod/github.com/cosmos/[email protected]/x/simulation/simulate.go:44 +0x98
github.com/cosmos/cosmos-sdk/x/simulation.SimulateFromSeedX({_, _}, {_, _}, {_, _}, _, _, _, {_, ...}, ...)
/Users/devdammit/.gvm/pkgsets/go1.23.3/global/pkg/mod/github.com/cosmos/[email protected]/x/simulation/simulate.go:119 +0x428
github.com/cosmos/cosmos-sdk/simsx.RunWithSeed[...]({0x1031569c0, _}, {{0x0, 0x0}, {0x0, 0x0}, {0x0, 0x0}, 0x0, {0x0, ...}, ...}, ...)
/Users/devdammit/.gvm/pkgsets/go1.23.3/global/pkg/mod/github.com/cosmos/[email protected]/simsx/runner.go:156 +0x5b0
kepler/app.BenchmarkFullAppSimulation(0x14000142788?)
/Users/devdammit/workspace/dittonetwork/kepler/app/sim_bench_test.go:21 +0x1d0
testing.(*B).runN(0x14000142788, 0x1)
/Users/devdammit/.gvm/gos/go1.23.3/src/testing/benchmark.go:193 +0x128
testing.(*B).run1.func1()
/Users/devdammit/.gvm/gos/go1.23.3/src/testing/benchmark.go:215 +0x4c
created by testing.(*B).run1 in goroutine 1
/Users/devdammit/.gvm/gos/go1.23.3/src/testing/benchmark.go:208 +0x90
|
Yes! This has been fixed in the SDK: cosmos/cosmos-sdk#22726 |
|
Fixed in last commit cc @Pantani, ready to merge now 👍🏾 |
|
There is a deprecated decoded string into the |
Pantani
approved these changes
Dec 6, 2024
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #4423
This PR focuses solely on simulations for modules and the app using the new simx framework.