refactor(templates): use go context instead of sdk.Context #4445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienrbrt
requested review from
ilgooz,
jeronimoalbi and
Pantani
as code owners
github-actions
bot
added
component:ci
Pantani
previously approved these changes
Dec 16, 2024
|
The tests are falling because we need to unwrap the context again to get the block time into the simulation methods |
Yep, my bad, my search and replace shouldn't have touched the app folder. |
Pantani
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #4432
Removal of sdk.Context in modules. The app (v1) should still have sdk.Context while in sdk v2 not.
Next PR is integrating SDK v2.