feat: integrate with v0.52.x (2/n)

[julienrbrt]

Follow-up of #4289

The previous PR implemented the required changes for the app and the minimum changes for the modules.

• Use environment
• Delete AppModuleBasic
• Split files in module.go / depinject.go
• Simplify testing

The follow-up will do the two remaining tasks:

• Use core services / delete sdk.Context
• Use new simulation framework

While the modules are working fine currently for 0.52, this bring them to the latest recommendations. The changes allows to make modules simpler, and baseapp and v2 compatible.

[Pantani]

@julienrbrt the export genesis command is not working

[IGNITE] error exporting state: genesis export error in mars: collections: not found: key 'no_key' of type github.com/cosmos/gogoproto/mars.mars.v1.Bla

[Pantani]

besides the genesis export command, everything is ok for me

[Pantani]

The app/export.go file still has sdk.Context declaration and sdk.ValAddressFromBech32(addr) decode. Do you know if we have plans to cover the refactor later?

[Pantani]

I also got some unhandled errors not in this PR. In the cmd/chaind/cmd/testnet.go there is a block:

app.DistrKeeper.ValidatorHistoricalRewards.Set(ctx, collections.Join(sdk.ValAddress(validator), uint64(0)), distrtypes.NewValidatorHistoricalRewards(sdk.DecCoins{}, 1))
app.DistrKeeper.ValidatorCurrentRewards.Set(ctx, validator, distrtypes.NewValidatorCurrentRewards(sdk.DecCoins{}, 1))
app.DistrKeeper.ValidatorsAccumulatedCommission.Set(ctx, validator, distrtypes.InitialValidatorAccumulatedCommission())
app.DistrKeeper.ValidatorOutstandingRewards.Set(ctx, validator, distrtypes.ValidatorOutstandingRewards{Rewards: sdk.DecCoins{}})

and deprecated addresses decode in this file also

[Pantani]

Maybe we should avoid scaffolding NewWeightedProposalMsg method into the x/chain/module/simulation.go file

[Pantani]

we need refactor the FindAccount method from x/module/simulation/helpers.go

[Pantani]

wdyt remove the ErrSample from x/module/types/errors.go

[Pantani]

I tried to review the PR, but it was hard because there were many files and also too many plush file changes. So, I scaffolded a chain and some types so I could check all the codes and change, and these are all my suggestions; I think we don't need to solve everything in this PR. We can open issues to solve later and before the v29. wdyt?

[julienrbrt]

The app/export.go file still has sdk.Context declaration and sdk.ValAddressFromBech32(addr) decode. Do you know if we have plans to cover the refactor later?

Right, the sdk.Context removal will be done later as said in the description, same for simulations as it will be completely rewritten:

[julienrbrt]

I'll check about export, but the rest was indeed planned for a follow-up

[julienrbrt]

good point on the error, made me remember we have errors/v2! Updated. The rest will be done in a follow up.