-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle multi picture objects (MPO) #35
Comments
Since there are many image formats https://en.wikipedia.org/wiki/Image_file_formats. I think it would be a good idea to provide an option to pass the image file format list via the function call (encode_images) or something. |
Thanks for the feedback. We would try to expand the supported formats. (However, these would be restricted by the formats supported by Pillow library that we're using to load the images) |
MPO are supported. The single line of code I provided works.
…On Tue, Oct 8, 2019, 8:23 AM Tanuj Jain ***@***.***> wrote:
Thanks for the feedback.
We would try to expand the supported formats. (However, these would be
restricted by the formats supported by Pillow library that we're using to
load the images)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#35?email_source=notifications&email_token=ABIU656XLDPQKPENFRJFTS3QNSQXBA5CNFSM4I5YCZ42YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAUR7YA#issuecomment-539566048>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABIU657G7FAWLZH5VM4VIYDQNSQXBANCNFSM4I5YCZ4Q>
.
|
Yes, we agree. We wish to take it up as a more involved theme to allow as many image formats as we can. This entails:
|
Addressed in PR #57 |
I have a LOT of images (roughly 1/3 of my entire personal library) that register in PIL as MPO. Your code barfs on all of them, but changing image_utils.py line 15 to IMG_FORMATS = ['JPEG', 'PNG', 'BMP', 'MPO'] fixes this.
I didn't want to submit a PR in case you already know this and it causes a headache somewhere else. If not, please change this.
The text was updated successfully, but these errors were encountered: