-
Notifications
You must be signed in to change notification settings - Fork 604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ir): more flexible dereferencing support for join right hand side #8992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kszucs
commented
Apr 18, 2024
kszucs
commented
Apr 18, 2024
kszucs
commented
Apr 18, 2024
kszucs
commented
Apr 18, 2024
kszucs
force-pushed
the
derefff
branch
3 times, most recently
from
April 19, 2024 10:15
2e2ce8e
to
1ec497f
Compare
kszucs
requested review from
cpcloud and
jcrist
and removed request for
cpcloud
April 22, 2024 16:07
kszucs
force-pushed
the
derefff
branch
7 times, most recently
from
April 24, 2024 09:01
7ad98df
to
53d02db
Compare
cpcloud
reviewed
Apr 24, 2024
ibis/backends/impala/tests/snapshots/test_sql/test_nested_join_base/out.sql
Show resolved
Hide resolved
cpcloud
approved these changes
Apr 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM mostly, just a few small requests.
Would really like to see a docstring for DerefMap
but I won't block on that.
kszucs
force-pushed
the
derefff
branch
2 times, most recently
from
April 25, 2024 14:06
e060461
to
3baedcc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables to use fields from parent tables of the join right hand side instead of enforcing to use the same exact table:
Identify ambiguous cases and raise an error, like the following case:
depends on:
fixes #8581