Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ir): more flexible dereferencing support for the right hand side of joins #8581

Closed
1 task done
kszucs opened this issue Mar 7, 2024 · 0 comments · Fixed by #8992
Closed
1 task done

feat(ir): more flexible dereferencing support for the right hand side of joins #8581

kszucs opened this issue Mar 7, 2024 · 0 comments · Fixed by #8992
Assignees
Labels
feature Features or general enhancements
Milestone

Comments

@kszucs
Copy link
Member

kszucs commented Mar 7, 2024

Is your feature request related to a problem?

The right hand side of joins is not dereferenced, for temporal joins we need more flexible dereferencing. Blocks #8412 #8537

Code of Conduct

  • I agree to follow this project's Code of Conduct
@kszucs kszucs added the feature Features or general enhancements label Mar 7, 2024
@kszucs kszucs self-assigned this Mar 7, 2024
@kszucs kszucs added this to the 9.0 milestone Mar 7, 2024
kszucs added a commit that referenced this issue Apr 25, 2024
#8992)

Enables to use fields from parent tables of the join right hand side
instead of enforcing to use the same exact table:

```py
t1 = ibis.table(name="t1", schema={"a": "int64", "b": "string"})
t2 = ibis.table(name="t2", schema={"c": "int64", "d": "string"})

t3 = t2.mutate(e=t2.c + 1)
joined = t1.join(t3, [t1.a == t2.c])  # here we use t2.c instead of t3.c
```

Identify ambiguous cases and raise an error, like the following case:

```py
t.join(t, [t.a == t.a])
```

depends on:
- #9043 
- #9041 

fixes #8581
@github-project-automation github-project-automation bot moved this from backlog to done in Ibis planning and roadmap Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Features or general enhancements
Projects
Archived in project
1 participant