feat(ir): more flexible dereferencing for join right-hand side #8916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @mfatihaktas |
|
There is a more complicated test case in the impala test suite, inspecting it. |
|
The multi-table dereference mapping calculation must be slightly smarter by tracking the distance from the target relations and picking the closest one (unless there are multiple ones at the same distance in which case an ambiguity error should be raised). |
|
@kszucs The two failures are pretty easy to fix. Otherwise, is this PR ready to go in? |
gforsyth
force-pushed
the
join-deref-rhs
branch
from
8ac7024 to
462a58a
Compare
|
CI is green if @kszucs is happy with this. |
cpcloud
requested changes
Apr 15, 2024
| @@ -62,7 +62,7 @@ INNER JOIN ( | |||
| GROUP BY | |||
| 1 | |||
| ) AS `t10` | |||
| ON `t8`.`d` = `t10`.`d` | |||
| ON `t10`.`d` = `t10`.`d` | |||
There was a problem hiding this comment.
This doesn't look correct to me. Should be t8 as it was before.
|
No, I am not happy with this yet. |
|
Should we close this in favor of #8992? |
|
Yes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The join dereferencing logic required explicit references to the exact right hand side table which disallowed more convenient syntaxes like
t1.join(t2.at_time(t1.c), [t1.a == t2.d]).Resolves #8581