Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deps): install project and dev and test dependencies in devcontainer #10544

Merged
merged 14 commits into from
Dec 13, 2024

Conversation

nickpowersys
Copy link
Contributor

@nickpowersys nickpowersys commented Nov 29, 2024

Description of changes

  • Install uv in development container
  • Use uv sync to install project and its dependencies, dev and tests dependency groups, and selected optional dependencies/extras
  • Switch the container user to the vscode user
  • Give the vscode user ownership and permissions to the uv virtual environment and other directories needed for running uv run pytest -m core
  • Enables use of Git within container, so commits can be pushed to/pulled from remote

Issues closed

Copy link
Contributor

ACTION NEEDED

Ibis follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message.

Please update your PR title and description to match the specification.

@nickpowersys nickpowersys changed the title feat(deps): Install project, dev and test dependencies in devcontainer feat(deps): Install project and dev and test dependencies in devcontainer Nov 29, 2024
@nickpowersys nickpowersys changed the title feat(deps): Install project and dev and test dependencies in devcontainer feat(deps): install project and dev and test dependencies in devcontainer Nov 29, 2024
Copy link
Member

@cpcloud cpcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legit, thanks!

@nickpowersys
Copy link
Contributor Author

nickpowersys commented Dec 10, 2024

I am working on docs, and will finalize them this week. I also have some updates to the container build.

@github-actions github-actions bot added the docs Documentation related issues or PRs label Dec 12, 2024
@nickpowersys nickpowersys marked this pull request as ready for review December 12, 2024 14:04
@nickpowersys nickpowersys requested a review from cpcloud December 12, 2024 14:05
@cpcloud cpcloud merged commit e593495 into ibis-project:main Dec 13, 2024
89 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related issues or PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pre-install dev and core test dependencies in devcontainer container
2 participants