Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pre-install dev and core test dependencies in devcontainer container #10532

Closed
1 task done
nickpowersys opened this issue Nov 25, 2024 · 1 comment · Fixed by #10544
Closed
1 task done

Pre-install dev and core test dependencies in devcontainer container #10532

nickpowersys opened this issue Nov 25, 2024 · 1 comment · Fixed by #10544
Assignees
@nickpowersys
Labels
feature Features or general enhancements

Comments

@nickpowersys
Copy link
Contributor

Is your feature request related to a problem?

I was hoping to have dev dependencies ready to use, and to run core tests without needing to install both sets of dependencies.

What is the motivation behind your request?

Having this context ready to use through VS Code, with any OS supporting devcontainers, seems like something that most contributors using devcontainers would want, instead of each contributor needing to install these dependencies into the container.

I want to be able to run uv commands to interact with the environment, for example updating dependency groups as needed while supporting a given backend.

Describe the solution you'd like

I would like to have a uv .venv that is activated so that when a terminal becomes available after container start-up, it is possible to run the commands

uv pip list and see all of the installed dependencies,

and

pytest -m core to run the core tests.

What version of ibis are you running?

9.5.0

What backend(s) are you using, if any?

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@nickpowersys nickpowersys added the feature Features or general enhancements label Nov 25, 2024
@nickpowersys
Copy link
Contributor Author

/take

@nickpowersys nickpowersys changed the title Pre-install dev and core test dependencies in devcontainer container /take Pre-install dev and core test dependencies in devcontainer container Nov 25, 2024
@nickpowersys nickpowersys mentioned this issue Nov 29, 2024
Merged
cpcloud pushed a commit that referenced this issue Dec 13, 2024
@nickpowersys
feat(deps): install project and dev and test dependencies in devconta…
e593495 
…iner (#10544)

## Description of changes
* Install `uv` in development container
* Use `uv sync` to install project and its dependencies, dev and tests
dependency groups, and selected optional dependencies/extras
* Switch the container user to the `vscode` user
* Give the `vscode` user ownership and permissions to the `uv` virtual
environment and other directories needed for running `uv run pytest -m
core`
* Enables use of Git within container, so commits can be pushed
to/pulled from remote

## Issues closed
* Resolves #10532
@github-project-automation github-project-automation bot moved this from backlog to done in Ibis planning and roadmap Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nickpowersys nickpowersys

Labels
feature Features or general enhancements
Projects
Ibis planning and roadmap
Status: done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(deps): install project and dev and test dependencies in devcontainer nickpowersys/ibis
1 participant
@nickpowersys