feat(parser): add a shapefile parser #1056
Conversation
zarov
force-pushed
the
shapefile
branch
2 times, most recently
from
35bab6c to
5c599bf
Compare
|
This PR can be reviewed now that #1033 has been merged. |
examples/shapefile.html
Outdated
|
|
||
| // Load all the necessary files for a shapefile, parse them and | ||
| // display them. | ||
| Promise.all([ |
There was a problem hiding this comment.
could you add Fetcher.Shape(baseUrl, extentionfiles = {shp: 'shp',.... }, networkOptions)?
There was a problem hiding this comment.
So I pushed a quick draft, let me know what you think
zarov
force-pushed
the
shapefile
branch
2 times, most recently
from
951ef5d to
c0df145
Compare
|
I completed the documentation and rebased everything in 2 commits |
|
I have some comments:
|
|
src/Converter/Feature2Texture.js
Outdated
| function drawFeature(ctx, feature, origin, scale, extent, style = {}) { | ||
| let gStyle = style; | ||
| // Determinate with radius point | ||
| const px = 0.01; |
There was a problem hiding this comment.
px needs to be determinate with radius, because if radius increases then the condition is wrong.
There was a problem hiding this comment.
Damn I copied/pasted it without noticing the comment, my bad ! Fixing it.
There was a problem hiding this comment.
So this seems complicated to do: it depends a lot on the current projection/view, and I don't think this will simply things. What about allowing only a maximum radius size ? I don't see a case where a point is larger than 30 or 50px, and unless someone displays this point on a globe with a zoom at 0, there will be no artefact. What do you say ?
There was a problem hiding this comment.
Nervemind, it is done simply in fact, my bad
fixed with #1068 |
The parser can take into account four files: shp, shx, dbf and prj. It uses https://www.npmjs.com/package/shpjs An example and some data has been added.
The new multiple method can be used to load a bunch of files having the same base url, like the shapefile system for example.
|
|
||
| // cross multiplication to know in the extent system the real size of | ||
| // the point | ||
| px = gStyle.radius * (extentDim.x / 256); |
There was a problem hiding this comment.
you could use ctx.canvas.width instead of 256
The parser can take into account four files: shp, shx, dbf and prj. It
uses https://www.npmjs.com/package/shpjs
An example and some data has been added.
This PR should not be merged before #1033