Process and Layer imagery/elevation #1068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gchoqueux
force-pushed
the
process_imagery
branch
from
23bad33 to
32cdeb4
Compare
the problem comes from LayeredMaterialNodeProcessing.updateLayeredMaterialNodeImagery. No texture is provided for a tile, if only one of them is outside the source extent. Visit PR iTowns#1067 iTowns#1067 to follow the issue.
gchoqueux
force-pushed
the
process_imagery
branch
from
32cdeb4 to
5eb91a4
Compare
zarov
reviewed
Mar 12, 2019
| @@ -54,6 +43,36 @@ function refinementCommandCancellationFn(cmd) { | |||
| return !cmd.requester.material.visible; | |||
| } | |||
|
|
|||
| function handlingError(err, node, layer, targetLevel, view) { | |||
There was a problem hiding this comment.
Couldn't this be moved to TileMesh or in a ProcessHelper file along with buildCommand below ?
There was a problem hiding this comment.
I move handlingError but not buildCommand is specify for each process
…olorLayersOrder in tileLayer
…ssing. extract common functions in layered material processing and feature processing: * The target is principally to highlight the common parties and simplify the refactoring in progress. other: * remove useless test command parameter.
to follow issue visiting: iTowns#1069
gchoqueux
force-pushed
the
process_imagery
branch
from
5eb91a4 to
17ba989
Compare
This was referenced Mar 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Work on
processandLayerimagery/elevation: