Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Cruise mode MSP box active check #7045

Conversation

nmaggioni
Copy link
Contributor

Fixes iNavFlight/inav-configurator#1279 for #6904.

Paging @shellixyz for review.

@DzikuVx DzikuVx added this to the 3.0 milestone May 31, 2021
@DzikuVx DzikuVx merged commit e5f75a6 into iNavFlight:release_3.0.0 May 31, 2021
@MrD-RC
Copy link
Collaborator

MrD-RC commented May 31, 2021

Does this also fix failsafe, which was also always highlighted? iNavFlight/inav-configurator#1264 (comment)

@nmaggioni nmaggioni deleted the nm_fix_msp_box_cruise_always_active branch May 31, 2021 07:14
@nmaggioni
Copy link
Contributor Author

@MrD-RC FS seems to light up correctly here. Stupid question: is your TX turned on? FS will be enabled regardless of its mode's range if the RX is not receiving data.

@MrD-RC
Copy link
Collaborator

MrD-RC commented May 31, 2021

@nmaggioni That would be pretty silly. But honestly, I can’t confirm or deny 🤣 If it is something that foolish, it caught @Jetrell out too. I will double check and follow up shortly.

@MrD-RC
Copy link
Collaborator

MrD-RC commented May 31, 2021

Failsafe is fine on RC1. My Rx was unplugged 🤣

@shellixyz
Copy link
Collaborator

Would have been better IMO to fix CHECK_ACTIVE_BOX

@shellixyz
Copy link
Collaborator

#7049

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants