Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new cruise mode to modes ordering #1264

Merged

Conversation

MrD-RC
Copy link
Collaborator

@MrD-RC MrD-RC commented May 12, 2021

I thought I left Cruise in there. It wasn't, so it's back now we have a Cruise mode again.

@Jetrell
Copy link

Jetrell commented May 13, 2021

@MrD-RC Does this PR also prevent NavCruise and Failsafe modes from highlighting blue when not active?

modes

@MrD-RC
Copy link
Collaborator Author

MrD-RC commented May 13, 2021

@Jetrell at first glance, that doesn't appear to be caused by the ordering. I removed the ordering code, and both remain highlighted.
Modes

I added the IDs as debug, and the ID matches the original ID, so no ordering has taken place.
modes 2
...and the ordered version for comparison
modes 3
The highlighting is based on the original ID.

I also removed every range except for those 2, and they stay highlighted, no matter what channel I select, or where I move the ranges. I think this is something in the firmware causing it.

@Jetrell
Copy link

Jetrell commented May 13, 2021

@MrD-RC That is odd. Thank you for looking at it. Maybe it can be fixed at some later time.
For now its good to have the two Cruise modes together. 👍

@DzikuVx DzikuVx added this to the 3.0 milestone May 15, 2021
@DzikuVx DzikuVx merged commit 9dbf1d7 into iNavFlight:master May 15, 2021
@MrD-RC MrD-RC deleted the add-new-cruise-mode-to-modes-ordering branch September 4, 2021 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants