Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Meta: Audit public dependencies #2874

Closed
5 tasks done
seanmonstar opened this issue May 26, 2022 · 1 comment
Closed
5 tasks done

Meta: Audit public dependencies #2874

seanmonstar opened this issue May 26, 2022 · 1 comment
Labels
B-breaking-change Blocked: this is an "API breaking change". B-upstream Blocked: needs a change in a dependency or the compiler.
Milestone
1.0

Comments

@seanmonstar
Copy link
Member

seanmonstar commented May 26, 2022 •
edited
Loading

As part of reaching hyper 1.0, we need to audit the "public" dependencies to make sure that:

  • We actually mean for that dependency to be exposed.
  • The dependency is stable.

This list might be incomplete, but currently has:
@seanmonstar seanmonstar added the B-breaking-change Blocked: this is an "API breaking change". label May 26, 2022
@seanmonstar seanmonstar added this to the 1.0 milestone May 26, 2022
@hawkw
Copy link
Contributor

hawkw commented Jun 10, 2022

I think the Tokio 1.0 checkmark should be checked off, given that Tokio's io traits are stable :)

@seanmonstar seanmonstar moved this to Blocked in hyper 1.0 Jun 15, 2022
@seanmonstar seanmonstar modified the milestones: 1.0 RC1, 1.0 Final Aug 22, 2022
@seanmonstar seanmonstar added the B-upstream Blocked: needs a change in a dependency or the compiler. label May 18, 2023
@seanmonstar seanmonstar mentioned this issue Sep 5, 2023
Closed
@seanmonstar seanmonstar mentioned this issue Sep 18, 2023
Merged
RamziA961 added a commit to RamziA961/hyper that referenced this issue Sep 27, 2023
@RamziA961
feat(upgrade): introduce tracing as an optional unstable feature
227be03 
This change allow users to opt out of tracing via the `tracing` crate
by adding tracing as an optional feature. This change is part of the
effort, outlined in hyperium#2874, to reach hyper 1.0.

Closes hyperium#3319
BREAKING CHANGES: tracing is disabled by default and requires users to
opt in to revert to previous behavior.
@RamziA961 RamziA961 mentioned this issue Sep 27, 2023
Merged
RamziA961 added a commit to RamziA961/hyper that referenced this issue Sep 27, 2023
@RamziA961
feat(upgrade): introduce tracing as an optional unstable feature
57c5827 
This change allow users to opt out of tracing via the `tracing` crate
by adding tracing as an optional feature. This change is part of the
effort, outlined in hyperium#2874, to reach hyper 1.0.

Closes hyperium#3319
BREAKING CHANGES: tracing is disabled by default and requires users to
opt in to revert to previous behavior.
RamziA961 added a commit to RamziA961/hyper that referenced this issue Sep 27, 2023
@RamziA961
feat(upgrade): introduce tracing as an optional unstable feature
25f10dc 
This change allow users to opt out of tracing via the `tracing` crate
by adding tracing as an optional feature. This change is part of the
effort, outlined in hyperium#2874, to reach hyper 1.0.

Closes hyperium#3319
BREAKING CHANGES: tracing is disabled by default and requires users to
opt in to revert to previous behavior.
RamziA961 added a commit to RamziA961/hyper that referenced this issue Sep 27, 2023
@RamziA961
feat(upgrade): introduce tracing as an optional unstable feature
a2f89d0 
This change allow users to opt out of tracing via the `tracing` crate
by adding tracing as an optional feature. This change is part of the
effort, outlined in hyperium#2874, to reach hyper 1.0.

Closes hyperium#3319
BREAKING CHANGES: tracing is disabled by default and requires users to
opt in to revert to previous behavior.
RamziA961 added a commit to RamziA961/hyper that referenced this issue Sep 28, 2023
@RamziA961
feat(trace): add internal tracing macro module
6bc791e 
Introduce several macros that act as wrappers around the `tracing`
module's macros to allow for more concise syntax for conditional
compilation of `tracing` macro calls. As `tracing` is unstable,
the new `trace` module will facilitate transitioning `tracing`
to an optional feature, as outlined in hyperium#2874 and hyperium#3326.

BREAKING CHANGES: Integration of macros requires the replacement of
uses of `trace` macros.
RamziA961 added a commit to RamziA961/hyper that referenced this issue Sep 28, 2023
@RamziA961
refactor(multiple): subsitute calls to tracing macros with new intern…
d01afc3 
…al trace module

Refactor code to utilize tracing macros from the new `trace` module and
fix breaking changes described in commit aba2a35. Part of the effort to
transition `tracing` to an unstable feature hyperium#3326 #hyperium#2874.
RamziA961 added a commit to RamziA961/hyper that referenced this issue Sep 28, 2023
@RamziA961
feat(trace): introduce a cfg flag for the unstable tracing feature
ae429f1 
Add a `rustc` configuration flag (`hyper_unstable_tracing`) that must be passed
to the compiler when using the `tracing` feature. Throw a compiler error if `tracing`
is enabled without the flag. Part of the effort to transtition `tracing` to an
unstable dependecy. See hyperium#3326 and hyperium#2874.
seanmonstar pushed a commit that referenced this issue Oct 2, 2023
@RamziA961
feat(upgrade): introduce tracing as an optional unstable feature (#3326)
da3fc76 
* feat(upgrade): introduce tracing as an optional unstable feature

This change allow users to opt out of tracing via the `tracing` crate
by adding tracing as an optional feature. This change is part of the
effort, outlined in #2874, to reach hyper 1.0.

- Introduce several macros that act as wrappers around the `tracing`
module's macros to allow for more concise syntax for conditional
compilation of `tracing` macro calls. As `tracing` is unstable,
the new `trace` module will facilitate transitioning `tracing`
to an optional feature, as outlined in #2874 and #3326.
- Refactor code to utilize tracing macros from the new `trace` module.
- Add a `rustc` configuration flag (`hyper_unstable_tracing`) that must be passed
to the compiler when using the `tracing` feature. Throw a compiler error if `tracing`
is enabled without the flag. Part of the effort to transtition `tracing` to an
unstable dependecy. See #3326 and #2874.
- Modify `package.metadata.docs.rs` in `Cargo.toml` to include `tracing`
to list of `features` and `--cfg hyper_unstable_tracing` to the list of
`rustdoc-args`.
- Add unstable section to `lib.rs` detailing unstable features. Add information about `tracing`
and `ffi` to unstable features section.
- Log errors as a field rather than part of a formatted string.

Closes #3319

BREAKING CHANGES: tracing is disabled by default and requires users to
  opt in to an unstable feature to revert to previous behavior.
@seanmonstar seanmonstar moved this from Blocked to In Progress in hyper 1.0 Nov 15, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in hyper 1.0 Nov 15, 2023
0xE282B0 pushed a commit to 0xE282B0/hyper that referenced this issue Jan 12, 2024
@RamziA961 @0xE282B0
feat(upgrade): introduce tracing as an optional unstable feature (hyp…
5d09b18 
…erium#3326)

This change allow users to opt out of tracing via the `tracing` crate
by adding tracing as an optional feature. This change is part of the
effort, outlined in hyperium#2874, to reach hyper 1.0.

- Introduce several macros that act as wrappers around the `tracing`
module's macros to allow for more concise syntax for conditional
compilation of `tracing` macro calls. As `tracing` is unstable,
the new `trace` module will facilitate transitioning `tracing`
to an optional feature, as outlined in hyperium#2874 and hyperium#3326.
- Refactor code to utilize tracing macros from the new `trace` module.
- Add a `rustc` configuration flag (`hyper_unstable_tracing`) that must be passed
to the compiler when using the `tracing` feature. Throw a compiler error if `tracing`
is enabled without the flag. Part of the effort to transtition `tracing` to an
unstable dependecy. See hyperium#3326 and hyperium#2874.
- Modify `package.metadata.docs.rs` in `Cargo.toml` to include `tracing`
to list of `features` and `--cfg hyper_unstable_tracing` to the list of
`rustdoc-args`.
- Add unstable section to `lib.rs` detailing unstable features. Add information about `tracing`
and `ffi` to unstable features section.
- Log errors as a field rather than part of a formatted string.

Closes hyperium#3319

BREAKING CHANGES: tracing is disabled by default and requires users to
  opt in to an unstable feature to revert to previous behavior.
0xE282B0 pushed a commit to 0xE282B0/hyper that referenced this issue Jan 16, 2024
@RamziA961 @0xE282B0
feat(upgrade): introduce tracing as an optional unstable feature (hyp…
e5f09cd 
…erium#3326)

This change allow users to opt out of tracing via the `tracing` crate
by adding tracing as an optional feature. This change is part of the
effort, outlined in hyperium#2874, to reach hyper 1.0.

- Introduce several macros that act as wrappers around the `tracing`
module's macros to allow for more concise syntax for conditional
compilation of `tracing` macro calls. As `tracing` is unstable,
the new `trace` module will facilitate transitioning `tracing`
to an optional feature, as outlined in hyperium#2874 and hyperium#3326.
- Refactor code to utilize tracing macros from the new `trace` module.
- Add a `rustc` configuration flag (`hyper_unstable_tracing`) that must be passed
to the compiler when using the `tracing` feature. Throw a compiler error if `tracing`
is enabled without the flag. Part of the effort to transtition `tracing` to an
unstable dependecy. See hyperium#3326 and hyperium#2874.
- Modify `package.metadata.docs.rs` in `Cargo.toml` to include `tracing`
to list of `features` and `--cfg hyper_unstable_tracing` to the list of
`rustdoc-args`.
- Add unstable section to `lib.rs` detailing unstable features. Add information about `tracing`
and `ffi` to unstable features section.
- Log errors as a field rather than part of a formatted string.

Closes hyperium#3319

BREAKING CHANGES: tracing is disabled by default and requires users to
  opt in to an unstable feature to revert to previous behavior.

Signed-off-by: Sven Pfennig <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
B-breaking-change Blocked: this is an "API breaking change". B-upstream Blocked: needs a change in a dependency or the compiler.
Projects
No open projects
hyper 1.0
Status: Done
Milestone
1.0
Development

No branches or pull requests
2 participants
@seanmonstar @hawkw