Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make tracing an unstable feature #3319

Closed
Tracked by #2874
seanmonstar opened this issue Sep 18, 2023 · 1 comment · Fixed by #3326
Closed
Tracked by #2874

Make tracing an unstable feature #3319

seanmonstar opened this issue Sep 18, 2023 · 1 comment · Fixed by #3326
Labels
A-dependencies Area: library dependencies. B-breaking-change Blocked: this is an "API breaking change". C-feature Category: feature. This is adding a new feature. E-easy Effort: easy. A task that would be a great starting point for a new contributor.
Milestone
1.0

Comments

@seanmonstar
Copy link
Member

No description provided.

@seanmonstar seanmonstar mentioned this issue Sep 18, 2023
Closed
5 tasks
@seanmonstar seanmonstar added this to the 1.0 milestone Sep 18, 2023
@seanmonstar seanmonstar added E-easy Effort: easy. A task that would be a great starting point for a new contributor. C-feature Category: feature. This is adding a new feature. B-breaking-change Blocked: this is an "API breaking change". A-dependencies Area: library dependencies. labels Sep 18, 2023
@RamziA961
Copy link
Contributor

RamziA961 commented Sep 26, 2023 •
edited
Loading

Hello, I'm currently working on this.
I've already marked all usages of tracing and imports with #[cfg(feature = "tracing")].

I've also modified Cargo.toml, to make tracing optional and added tracing as a feature as such:

# Utilize tracing (currently unstable)
tracing = ["dep:tracing"]

Is there anything I am missing? If not, I can open a PR.

RamziA961 added a commit to RamziA961/hyper that referenced this issue Sep 27, 2023
@RamziA961
feat(upgrade): introduce tracing as an optional unstable feature
227be03 
This change allow users to opt out of tracing via the `tracing` crate
by adding tracing as an optional feature. This change is part of the
effort, outlined in hyperium#2874, to reach hyper 1.0.

Closes hyperium#3319
BREAKING CHANGES: tracing is disabled by default and requires users to
opt in to revert to previous behavior.
@RamziA961 RamziA961 mentioned this issue Sep 27, 2023
Merged
RamziA961 added a commit to RamziA961/hyper that referenced this issue Sep 27, 2023
@RamziA961
feat(upgrade): introduce tracing as an optional unstable feature
57c5827 
This change allow users to opt out of tracing via the `tracing` crate
by adding tracing as an optional feature. This change is part of the
effort, outlined in hyperium#2874, to reach hyper 1.0.

Closes hyperium#3319
BREAKING CHANGES: tracing is disabled by default and requires users to
opt in to revert to previous behavior.
RamziA961 added a commit to RamziA961/hyper that referenced this issue Sep 27, 2023
@RamziA961
feat(upgrade): introduce tracing as an optional unstable feature
25f10dc 
This change allow users to opt out of tracing via the `tracing` crate
by adding tracing as an optional feature. This change is part of the
effort, outlined in hyperium#2874, to reach hyper 1.0.

Closes hyperium#3319
BREAKING CHANGES: tracing is disabled by default and requires users to
opt in to revert to previous behavior.
RamziA961 added a commit to RamziA961/hyper that referenced this issue Sep 27, 2023
@RamziA961
feat(upgrade): introduce tracing as an optional unstable feature
a2f89d0 
This change allow users to opt out of tracing via the `tracing` crate
by adding tracing as an optional feature. This change is part of the
effort, outlined in hyperium#2874, to reach hyper 1.0.

Closes hyperium#3319
BREAKING CHANGES: tracing is disabled by default and requires users to
opt in to revert to previous behavior.
@seanmonstar seanmonstar moved this from Todo to In Progress in hyper 1.0 Sep 27, 2023
seanmonstar pushed a commit that referenced this issue Oct 2, 2023
@RamziA961
feat(upgrade): introduce tracing as an optional unstable feature (#3326)
da3fc76 
* feat(upgrade): introduce tracing as an optional unstable feature

This change allow users to opt out of tracing via the `tracing` crate
by adding tracing as an optional feature. This change is part of the
effort, outlined in #2874, to reach hyper 1.0.

- Introduce several macros that act as wrappers around the `tracing`
module's macros to allow for more concise syntax for conditional
compilation of `tracing` macro calls. As `tracing` is unstable,
the new `trace` module will facilitate transitioning `tracing`
to an optional feature, as outlined in #2874 and #3326.
- Refactor code to utilize tracing macros from the new `trace` module.
- Add a `rustc` configuration flag (`hyper_unstable_tracing`) that must be passed
to the compiler when using the `tracing` feature. Throw a compiler error if `tracing`
is enabled without the flag. Part of the effort to transtition `tracing` to an
unstable dependecy. See #3326 and #2874.
- Modify `package.metadata.docs.rs` in `Cargo.toml` to include `tracing`
to list of `features` and `--cfg hyper_unstable_tracing` to the list of
`rustdoc-args`.
- Add unstable section to `lib.rs` detailing unstable features. Add information about `tracing`
and `ffi` to unstable features section.
- Log errors as a field rather than part of a formatted string.

Closes #3319

BREAKING CHANGES: tracing is disabled by default and requires users to
  opt in to an unstable feature to revert to previous behavior.
@github-project-automation github-project-automation bot moved this from In Progress to Done in hyper 1.0 Oct 2, 2023
0xE282B0 pushed a commit to 0xE282B0/hyper that referenced this issue Jan 12, 2024
@RamziA961 @0xE282B0
feat(upgrade): introduce tracing as an optional unstable feature (hyp…
5d09b18 
…erium#3326)

This change allow users to opt out of tracing via the `tracing` crate
by adding tracing as an optional feature. This change is part of the
effort, outlined in hyperium#2874, to reach hyper 1.0.

- Introduce several macros that act as wrappers around the `tracing`
module's macros to allow for more concise syntax for conditional
compilation of `tracing` macro calls. As `tracing` is unstable,
the new `trace` module will facilitate transitioning `tracing`
to an optional feature, as outlined in hyperium#2874 and hyperium#3326.
- Refactor code to utilize tracing macros from the new `trace` module.
- Add a `rustc` configuration flag (`hyper_unstable_tracing`) that must be passed
to the compiler when using the `tracing` feature. Throw a compiler error if `tracing`
is enabled without the flag. Part of the effort to transtition `tracing` to an
unstable dependecy. See hyperium#3326 and hyperium#2874.
- Modify `package.metadata.docs.rs` in `Cargo.toml` to include `tracing`
to list of `features` and `--cfg hyper_unstable_tracing` to the list of
`rustdoc-args`.
- Add unstable section to `lib.rs` detailing unstable features. Add information about `tracing`
and `ffi` to unstable features section.
- Log errors as a field rather than part of a formatted string.

Closes hyperium#3319

BREAKING CHANGES: tracing is disabled by default and requires users to
  opt in to an unstable feature to revert to previous behavior.
0xE282B0 pushed a commit to 0xE282B0/hyper that referenced this issue Jan 16, 2024
@RamziA961 @0xE282B0
feat(upgrade): introduce tracing as an optional unstable feature (hyp…
e5f09cd 
…erium#3326)

This change allow users to opt out of tracing via the `tracing` crate
by adding tracing as an optional feature. This change is part of the
effort, outlined in hyperium#2874, to reach hyper 1.0.

- Introduce several macros that act as wrappers around the `tracing`
module's macros to allow for more concise syntax for conditional
compilation of `tracing` macro calls. As `tracing` is unstable,
the new `trace` module will facilitate transitioning `tracing`
to an optional feature, as outlined in hyperium#2874 and hyperium#3326.
- Refactor code to utilize tracing macros from the new `trace` module.
- Add a `rustc` configuration flag (`hyper_unstable_tracing`) that must be passed
to the compiler when using the `tracing` feature. Throw a compiler error if `tracing`
is enabled without the flag. Part of the effort to transtition `tracing` to an
unstable dependecy. See hyperium#3326 and hyperium#2874.
- Modify `package.metadata.docs.rs` in `Cargo.toml` to include `tracing`
to list of `features` and `--cfg hyper_unstable_tracing` to the list of
`rustdoc-args`.
- Add unstable section to `lib.rs` detailing unstable features. Add information about `tracing`
and `ffi` to unstable features section.
- Log errors as a field rather than part of a formatted string.

Closes hyperium#3319

BREAKING CHANGES: tracing is disabled by default and requires users to
  opt in to an unstable feature to revert to previous behavior.

Signed-off-by: Sven Pfennig <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-dependencies Area: library dependencies. B-breaking-change Blocked: this is an "API breaking change". C-feature Category: feature. This is adding a new feature. E-easy Effort: easy. A task that would be a great starting point for a new contributor.
Projects
No open projects
hyper 1.0
Status: Done
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

feat(upgrade): introduce tracing as an optional unstable feature RamziA961/hyper
2 participants
@seanmonstar @RamziA961