Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce tracing as a feature flag #3304

Closed
suryapandian opened this issue Sep 5, 2023 · 2 comments
Closed

Introduce tracing as a feature flag #3304

suryapandian opened this issue Sep 5, 2023 · 2 comments
Labels
B-breaking-change Blocked: this is an "API breaking change". C-feature Category: feature. This is adding a new feature.

Comments

@suryapandian
Copy link

Is your feature request related to a problem? Please describe.
Downstream crates that use hyper have feature flag tracing using which users can choose not to download tracing library or use tracing. Ex: octocrab has this feature. Even though octocrab has this feature tracing, the tracing library anyway gets downloaded since hyper is a dependency of octocrab and hyper downloads tracing libraries by default.

Describe the solution you'd like
Hyper to hide tracing behind a feature flag. That way, downstream crates that use hyper can choose not to have tracing if needed.

Describe alternatives you've considered
Downstream crates start using tracing by default

Additional context
By allowing tracing as a feature flag, users can opt out of tracing and avoid having to download tracing related libraries

@suryapandian suryapandian added the C-feature Category: feature. This is adding a new feature. label Sep 5, 2023
@seanmonstar
Copy link
Member

It would be nice. As part of #2874, we'll move tracing to an unstable feature in 1.0. We can't move it to a feature in 0.14, since it could suddenly mean tracing is disabled for people who have default-features = false.

@seanmonstar
Copy link
Member

This was done as part of v1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B-breaking-change Blocked: this is an "API breaking change". C-feature Category: feature. This is adding a new feature.
Projects
None yet
Development

No branches or pull requests

2 participants