feat(config): Allow users to set AP port #1420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrkfdn
reviewed
Mar 30, 2024
src/spotify.rs
Outdated
Comment on lines
140
to
142
| let ap_port = cfg.values().ap_port.unwrap_or(0); | ||
| if ap_port != 0 { | ||
| session_config.ap_port = Some(ap_port); | ||
| } |
There was a problem hiding this comment.
Do we need this intermediate 0 value? Could we also do it like this?
Suggested change
| let ap_port = cfg.values().ap_port.unwrap_or(0); | |
| if ap_port != 0 { | |
| session_config.ap_port = Some(ap_port); | |
| } | |
| session_config.ap_port = cfg.values().ap_port; |
There was a problem hiding this comment.
I was not sure if that would behave in the correct way (no parameter is set) when the ap-port option is missing in the config file. If that's the case, please feel free to apply the change, I wont be able in a couple of days.
There was a problem hiding this comment.
By default librespot sets ap_port to None: https://github.com/librespot-org/librespot/blob/4d35c5ffe222c839d1532d8afac78fe4c37043b3/core/src/config.rs#L33
However, if we wanted to be absolutely sure we could also use an if let expression here.
hrkfdn
changed the title
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Added a config option
ap-portto fix the port used to connect tospotifyand pass it tolibrespot. Fixes issues with restrictive firewalls, after settingap-port = 443in config file.Issue ticket number and link
Fixes #1404
Checklist before requesting a review
not performance improvements, etc.)