docs: Rename ap-port
option as ap_port
#1477
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1420 introduced the option
ac_port
to specify the port used by librespot.This option works great, except when following the documentation and example only.
ap-port
in librespot.ap_port
in ConfigValues.ac-port
in the documentation and in feat(config): Allow users to set AP port #1420, which doesn't work, as described below.In ncspot/config.toml:
ap-port = 443
does nothing, librespot uses port 4070ap_port = 443
librespot uses HTTPSDescribe your changes
Rename
ap-port
option byap_port
in the documentation.Issue ticket number and link
Checklist before requesting a review
not performance improvements, etc.)
Before merge
Should the changelog be updated too?
Changelog of 1.1.1 contains
ap-port
, which is misleading.