Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for --ap-port option #1404

Closed
gilcu3 opened this issue Feb 28, 2024 · 0 comments · Fixed by #1420
Closed

add support for --ap-port option #1404

gilcu3 opened this issue Feb 28, 2024 · 0 comments · Fixed by #1420
Labels
enhancement New feature or request

Comments

@gilcu3
Copy link
Contributor

gilcu3 commented Feb 28, 2024

Is your feature request related to a problem? Please describe.
This would solve issues with restrictive firewalls which block connections in the 4070 port but allow it on 443, which explains #90 and #1229

Describe the solution you'd like
librespot supports --ap-port 443 option, please make it available as an option to ncspot as well

PS:
I tested simply adding a line session_config.ap_port = Some(443); in function

ncspot/src/spotify.rs

Lines 131 to 141 in c0b78d3

pub fn session_config() -> SessionConfig {
let mut session_config = SessionConfig::default();
match env::var("http_proxy") {
Ok(proxy) => {
info!("Setting HTTP proxy {}", proxy);
session_config.proxy = Url::parse(&proxy).ok();
}
Err(_) => debug!("No HTTP proxy set"),
}
session_config
}

and it works on my environment. Adding proper support would require adding a config/command line option though.

@gilcu3 gilcu3 added the enhancement New feature or request label Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant