Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Exception Handling #93

Merged
merged 5 commits into from
Jun 20, 2021
Merged

Improve Exception Handling #93

merged 5 commits into from
Jun 20, 2021

Conversation

Benjamin-Frost
Copy link
Member

Closes: #74

@Benjamin-Frost Benjamin-Frost marked this pull request as ready for review June 18, 2021 13:02
SebastianWagner2
SebastianWagner2 approved these changes Jun 19, 2021
View reviewed changes
Copy link
Contributor

@SebastianWagner2 SebastianWagner2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exception Class Comments would be nice and the 3 comments are just suggestions

packages/AutoTDD-Core.package/ATDDRemoteClient.class/instance/throwExceptionForResponseCode..st Outdated Show resolved Hide resolved
packages/AutoTDD-Exceptions.package/ATDDAccessDeniedError.class/class/rateLimitMessage.st Show resolved Hide resolved
packages/AutoTDD-GUI.package/ATDDGitHubActionEditor.class/instance/hasValidUrl.st Outdated Show resolved Hide resolved
SebastianWagner2
SebastianWagner2 approved these changes Jun 19, 2021
View reviewed changes
Copy link
Contributor

@SebastianWagner2 SebastianWagner2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only recategorization (behavior to action)

packages/AutoTDD-GUI.package/ATDDRemoteEditor.class/instance/applyChanges.st Outdated Show resolved Hide resolved
packages/AutoTDD-GUI.package/ATDDRemoteEditor.class/instance/loadTargetSpecs.st Outdated Show resolved Hide resolved
packages/AutoTDD-GUI.package/ATDDRemoteEditor.class/instance/save.st Outdated Show resolved Hide resolved
@Benjamin-Frost Benjamin-Frost merged commit 33ec3a0 into dev Jun 20, 2021
@Benjamin-Frost Benjamin-Frost deleted the feat/exception-handling branch June 20, 2021 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SebastianWagner2 SebastianWagner2 SebastianWagner2 approved these changes

@kolioOtSofia kolioOtSofia kolioOtSofia approved these changes

Assignees

@Benjamin-Frost Benjamin-Frost

Labels
feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve Exception Handling
3 participants
@Benjamin-Frost @kolioOtSofia @SebastianWagner2