Merge pull request #93 from hpi-swa-teaching/feat/exception-handling

Improve Exception Handling
hpi-swa-teaching · Jun 20, 2021 · 33ec3a0 · 33ec3a0
2 parents 338b865 + e5955e8
commit 33ec3a0
Show file tree

Hide file tree

Showing 80 changed files with 168 additions and 129 deletions.
diff --git a/packages/AutoTDD-Core.package/ATDDGitHubAction.class/instance/pause.st b/packages/AutoTDD-Core.package/ATDDGitHubAction.class/instance/pause.st
@@ -0,0 +1,5 @@
+behaviour
+pause 
+
+	super pause. 
+	ATDDBrowser changedGitHubActions
diff --git a/packages/AutoTDD-Core.package/ATDDGitHubAction.class/methodProperties.json b/packages/AutoTDD-Core.package/ATDDGitHubAction.class/methodProperties.json
@@ -6,6 +6,7 @@
 		"symbol" : "sw 5/25/2021 22:27" },
 	"instance" : {
 		"initialize" : "BF 5/23/2021 21:18",
+		"pause" : "ng 6/18/2021 14:47",
 		"repositoryURL:" : "BF 5/23/2021 21:29",
 		"statusChanged" : "ClassTest 5/29/2021 19:31",
 		"updateStatus" : "ClassTest 5/28/2021 23:47" } }
diff --git a/packages/AutoTDD-Core.package/ATDDGitHubActionsClient.class/instance/errorDictionary.st b/packages/AutoTDD-Core.package/ATDDGitHubActionsClient.class/instance/errorDictionary.st
diff --git a/packages/AutoTDD-Core.package/ATDDGitHubActionsClient.class/instance/requestOn..st b/packages/AutoTDD-Core.package/ATDDGitHubActionsClient.class/instance/requestOn..st
@@ -14,7 +14,7 @@ requestOn: aString
 			response content; close ]
 		on: Error
 		do: [ :error |
-			[ GHAConnectionError signal: 'Connection failed: ' , error messageText ] fork.
+			[ ATDDConnectionError signal: 'Connection failed: ' , error messageText ] fork.
 			^ JsonObject new ].
 	^ response code
 		= 200

diff --git a/packages/AutoTDD-Core.package/ATDDGitHubActionsClient.class/methodProperties.json b/packages/AutoTDD-Core.package/ATDDGitHubActionsClient.class/methodProperties.json
@@ -2,13 +2,11 @@
 	"class" : {
 		 },
 	"instance" : {
-		"errorDictionary" : "ng 5/26/2021 19:13",
 		"getJsonForJobsForRepository:forWorkflowRunId:" : "BF 5/23/2021 21:30",
 		"getJsonForLatestWorkflowRunForRepository:" : "ng 5/27/2021 19:07",
 		"getJsonForWorkflow:" : "ng 5/23/2021 12:08",
 		"getJsonForWorkflowRunsForRepository:" : "ng 5/22/2021 19:16",
 		"getLogsForRepository:logId:" : "ng 5/27/2021 19:07",
 		"gitHubActionsApiUrl" : "ng 5/14/2021 16:07",
 		"mimeType" : "ng 5/14/2021 15:45",
-		"requestOn:" : "BF 5/28/2021 21:36",
-		"throwExceptionForResponseCode:" : "ng 5/26/2021 19:14" } }
+		"requestOn:" : "ng 6/18/2021 14:04" } }
diff --git a/packages/AutoTDD-Core.package/ATDDRemoteClient.class/instance/errorDictionary.st b/packages/AutoTDD-Core.package/ATDDRemoteClient.class/instance/errorDictionary.st
@@ -0,0 +1,8 @@
+accessing
+errorDictionary
+
+	^ IdentityDictionary newFrom: {
+		401 -> ATDDConnectionError.
+		403 -> ATDDAccessDeniedError.
+		404 -> ATDDNotFoundError
+	}
diff --git a/...nstance/throwExceptionForResponseCode..st → ...nstance/throwExceptionForResponseCode..st b/...nstance/throwExceptionForResponseCode..st → ...nstance/throwExceptionForResponseCode..st
diff --git a/packages/AutoTDD-Core.package/ATDDRemoteClient.class/methodProperties.json b/packages/AutoTDD-Core.package/ATDDRemoteClient.class/methodProperties.json
@@ -2,6 +2,8 @@
 	"class" : {
 		 },
 	"instance" : {
+		"errorDictionary" : "ng 6/18/2021 14:48",
+		"throwExceptionForResponseCode:" : "ng 6/18/2021 14:05",
 		"token" : "ClassTest 6/2/2021 18:44",
 		"token:" : "ClassTest 6/2/2021 18:44",
 		"userAgent" : "ClassTest 6/2/2021 18:45",

diff --git a/packages/AutoTDD-Core.package/ATDDRemoteTestingEntity.class/instance/pause.st b/packages/AutoTDD-Core.package/ATDDRemoteTestingEntity.class/instance/pause.st
@@ -2,5 +2,4 @@ behaviour
 pause
 
 	self terminateProcess.
-	super pause.
-	self updateStatus
+	super pause
diff --git a/packages/AutoTDD-Core.package/ATDDRemoteTestingEntity.class/methodProperties.json b/packages/AutoTDD-Core.package/ATDDRemoteTestingEntity.class/methodProperties.json
@@ -7,7 +7,7 @@
 		"internalStatus" : "ClassTest 6/2/2021 17:54",
 		"internalStatus:" : "ClassTest 5/29/2021 19:42",
 		"newRefreshProcess" : "sw 5/28/2021 18:04",
-		"pause" : "sw 5/28/2021 18:04",
+		"pause" : "ng 6/18/2021 14:46",
 		"pausedString" : "sw 5/28/2021 18:04",
 		"process" : "sw 5/28/2021 18:06",
 		"process:" : "sw 5/28/2021 18:06",

diff --git a/packages/AutoTDD-Core.package/ATDDTravisClient.class/instance/errorDictionary.st b/packages/AutoTDD-Core.package/ATDDTravisClient.class/instance/errorDictionary.st
diff --git a/packages/AutoTDD-Core.package/ATDDTravisClient.class/instance/requestOn..st b/packages/AutoTDD-Core.package/ATDDTravisClient.class/instance/requestOn..st
@@ -13,7 +13,7 @@ requestOn: aString
 			response content; close ]
 		on: Error
 		do: [ :error |
-			[ TCIConnectionError signal: 'Connection failed: ' , error messageText ] fork.
+			[ ATDDConnectionError signal: 'Connection failed: ' , error messageText ] fork.
 			^ JsonObject new ].
 
 	^ response code

diff --git a/...es/AutoTDD-Core.package/ATDDTravisClient.class/instance/throwExceptionForResponseCode..st b/...es/AutoTDD-Core.package/ATDDTravisClient.class/instance/throwExceptionForResponseCode..st
diff --git a/packages/AutoTDD-Core.package/ATDDTravisClient.class/methodProperties.json b/packages/AutoTDD-Core.package/ATDDTravisClient.class/methodProperties.json
@@ -2,7 +2,6 @@
 	"class" : {
 		 },
 	"instance" : {
-		"errorDictionary" : "PS 7/25/2014 17:01",
 		"getJsonForBuild:" : "CW 2/25/2016 10:14",
 		"getJsonForBuildsOfRepository:" : "PS 5/19/2014 17:44",
 		"getJsonForJob:" : "PS 5/19/2014 14:40",
@@ -12,8 +11,7 @@
 		"isJson:" : "PS 6/11/2014 13:56",
 		"mimeType" : "PS 5/18/2014 18:04",
 		"requestAPIOn:" : "maf 12/5/2017 14:41",
-		"requestOn:" : "ls 7/25/2019 15:30",
-		"throwExceptionForResponseCode:" : "PS 6/23/2014 15:55",
+		"requestOn:" : "ng 6/18/2021 14:04",
 		"travisApiUrl" : "PS 6/19/2014 09:57",
 		"usePro" : "PS 6/19/2014 09:56",
 		"usePro:" : "ls 7/25/2019 15:20" } }
diff --git a/packages/AutoTDD-Core.package/ATDDTravisRepository.class/instance/validate..st b/packages/AutoTDD-Core.package/ATDDTravisRepository.class/instance/validate..st
@@ -1,4 +1,4 @@
 data-processing
 validate: aString
 
-	(aString matchesRegex: self class validSlug) ifFalse: [ TCINoValidSlugError signal ]
+	(aString matchesRegex: self class validSlug) ifFalse: [ ATDDNoValidSlugError signal ]
diff --git a/packages/AutoTDD-Core.package/ATDDTravisRepository.class/methodProperties.json b/packages/AutoTDD-Core.package/ATDDTravisRepository.class/methodProperties.json
@@ -29,5 +29,5 @@
 		"update" : "ls 7/11/2019 18:57",
 		"usePro" : "ls 6/5/2019 21:10",
 		"usePro:" : "ls 7/25/2019 14:13",
-		"validate:" : "vxr 7/4/2019 14:25",
+		"validate:" : "ng 6/18/2021 14:06",
 		"wrapAsJson:" : "vxr 7/4/2019 14:25" } }
diff --git a/packages/AutoTDD-Core.package/ATDDTravisStatus.class/instance/pause.st b/packages/AutoTDD-Core.package/ATDDTravisStatus.class/instance/pause.st
@@ -0,0 +1,5 @@
+behaviour
+pause 
+
+	super pause. 
+	ATDDBrowser changedTravisStatuses
diff --git a/packages/AutoTDD-Core.package/ATDDTravisStatus.class/methodProperties.json b/packages/AutoTDD-Core.package/ATDDTravisStatus.class/methodProperties.json
@@ -6,6 +6,7 @@
 		"symbol" : "sw 5/25/2021 22:21" },
 	"instance" : {
 		"initialize" : "BF 5/23/2021 21:18",
+		"pause" : "ng 6/18/2021 14:49",
 		"repositoryURL:" : "ls 7/25/2019 09:23",
 		"statusChanged" : "ClassTest 5/29/2021 19:36",
 		"updateStatus" : "ClassTest 5/28/2021 23:46",

diff --git a/packages/AutoTDD-Exceptions.package/ATDDAccessDeniedError.class/README.md b/packages/AutoTDD-Exceptions.package/ATDDAccessDeniedError.class/README.md
@@ -0,0 +1 @@
+An ATDDAccessDeniedError is thrown when the HTTP request results in a 403 (Forbidden) Error.
diff --git a/...dError.class/class/accessDeniedMessage.st → ...DAccessDeniedError.class/class/message.st b/...dError.class/class/accessDeniedMessage.st → ...DAccessDeniedError.class/class/message.st
@@ -1,4 +1,4 @@
 accessing
-accessDeniedMessage
+message
 
 	^ 'Access denied'
diff --git a/packages/AutoTDD-Exceptions.package/ATDDAccessDeniedError.class/class/rateLimitMessage.st b/packages/AutoTDD-Exceptions.package/ATDDAccessDeniedError.class/class/rateLimitMessage.st
@@ -0,0 +1,4 @@
+accessing
+rateLimitMessage
+
+	^ 'You have been rate-limited. This GitHub Action will now be paused. Consider providing a token to prevent this.'
diff --git a/packages/AutoTDD-Exceptions.package/ATDDAccessDeniedError.class/instance/defaultAction.st b/packages/AutoTDD-Exceptions.package/ATDDAccessDeniedError.class/instance/defaultAction.st
@@ -0,0 +1,4 @@
+priv handling
+defaultAction
+
+	^ Transcript show: self class message
diff --git a/packages/AutoTDD-Exceptions.package/ATDDAccessDeniedError.class/methodProperties.json b/packages/AutoTDD-Exceptions.package/ATDDAccessDeniedError.class/methodProperties.json
@@ -0,0 +1,6 @@
+{
+	"class" : {
+		"message" : "ng 6/18/2021 13:55",
+		"rateLimitMessage" : "BF 6/18/2021 14:51" },
+	"instance" : {
+		"defaultAction" : "ng 6/18/2021 13:53" } }
diff --git a/...HAAccessDeniedError.class/properties.json → ...DDAccessDeniedError.class/properties.json b/...HAAccessDeniedError.class/properties.json → ...DDAccessDeniedError.class/properties.json
@@ -4,10 +4,10 @@
 		 ],
 	"classvars" : [
 		 ],
-	"commentStamp" : "ng 5/28/2021 14:44",
+	"commentStamp" : "BF 6/19/2021 10:35",
 	"instvars" : [
 		 ],
-	"name" : "GHAAccessDeniedError",
+	"name" : "ATDDAccessDeniedError",
 	"pools" : [
 		 ],
 	"super" : "Error",

diff --git a/packages/AutoTDD-Exceptions.package/ATDDConnectionError.class/README.md b/packages/AutoTDD-Exceptions.package/ATDDConnectionError.class/README.md
@@ -0,0 +1 @@
+An ATDDConnectionError is thrown when the HTTP request results in a 401 (Unauthorized) Error.
diff --git a/...tionError.class/instance/defaultAction.st → ...tionError.class/instance/defaultAction.st b/...tionError.class/instance/defaultAction.st → ...tionError.class/instance/defaultAction.st
diff --git a/packages/AutoTDD-Exceptions.package/ATDDConnectionError.class/methodProperties.json b/packages/AutoTDD-Exceptions.package/ATDDConnectionError.class/methodProperties.json
@@ -0,0 +1,5 @@
+{
+	"class" : {
+		 },
+	"instance" : {
+		"defaultAction" : "ng 6/18/2021 14:03" } }
diff --git a/...TCINoValidSlugError.class/properties.json → ...ATDDConnectionError.class/properties.json b/...TCINoValidSlugError.class/properties.json → ...ATDDConnectionError.class/properties.json
@@ -4,10 +4,10 @@
 		 ],
 	"classvars" : [
 		 ],
-	"commentStamp" : "be 7/25/2019 10:29",
+	"commentStamp" : "BF 6/19/2021 10:35",
 	"instvars" : [
 		 ],
-	"name" : "TCINoValidSlugError",
+	"name" : "ATDDConnectionError",
 	"pools" : [
 		 ],
 	"super" : "Error",

diff --git a/...ckage/TCINoValidSlugError.class/README.md → ...kage/ATDDNoValidSlugError.class/README.md b/...ckage/TCINoValidSlugError.class/README.md → ...kage/ATDDNoValidSlugError.class/README.md
diff --git a/...ugError.class/class/noValidSlugMessage.st → ...ugError.class/class/noValidSlugMessage.st b/...ugError.class/class/noValidSlugMessage.st → ...ugError.class/class/noValidSlugMessage.st
diff --git a/...SlugError.class/instance/defaultAction.st → ...SlugError.class/instance/defaultAction.st b/...SlugError.class/instance/defaultAction.st → ...SlugError.class/instance/defaultAction.st
diff --git a/...alidSlugError.class/methodProperties.json → ...alidSlugError.class/methodProperties.json b/...alidSlugError.class/methodProperties.json → ...alidSlugError.class/methodProperties.json
diff --git a/...CIAccessDeniedError.class/properties.json → ...TDDNoValidSlugError.class/properties.json b/...CIAccessDeniedError.class/properties.json → ...TDDNoValidSlugError.class/properties.json
@@ -7,7 +7,7 @@
 	"commentStamp" : "be 7/25/2019 10:29",
 	"instvars" : [
 		 ],
-	"name" : "TCIAccessDeniedError",
+	"name" : "ATDDNoValidSlugError",
 	"pools" : [
 		 ],
 	"super" : "Error",

diff --git a/packages/AutoTDD-Exceptions.package/ATDDNotFoundError.class/README.md b/packages/AutoTDD-Exceptions.package/ATDDNotFoundError.class/README.md
@@ -0,0 +1 @@
+An ATDDNotFoundError is thrown when the HTTP request results in a 404 (Not Found) Error.
diff --git a/packages/AutoTDD-Exceptions.package/ATDDNotFoundError.class/class/message.st b/packages/AutoTDD-Exceptions.package/ATDDNotFoundError.class/class/message.st
@@ -0,0 +1,4 @@
+accessing
+message
+
+	^ 'Not Found'
diff --git a/packages/AutoTDD-Exceptions.package/ATDDNotFoundError.class/instance/defaultAction.st b/packages/AutoTDD-Exceptions.package/ATDDNotFoundError.class/instance/defaultAction.st
@@ -0,0 +1,4 @@
+priv handling
+defaultAction
+
+	^ Transcript show: self class message
diff --git a/packages/AutoTDD-Exceptions.package/ATDDNotFoundError.class/methodProperties.json b/packages/AutoTDD-Exceptions.package/ATDDNotFoundError.class/methodProperties.json
@@ -0,0 +1,5 @@
+{
+	"class" : {
+		"message" : "ng 6/18/2021 13:55" },
+	"instance" : {
+		"defaultAction" : "ng 6/18/2021 13:59" } }
diff --git a/.../GHAConnectionError.class/properties.json → ...e/ATDDNotFoundError.class/properties.json b/.../GHAConnectionError.class/properties.json → ...e/ATDDNotFoundError.class/properties.json
@@ -4,10 +4,10 @@
 		 ],
 	"classvars" : [
 		 ],
-	"commentStamp" : "ng 5/28/2021 14:45",
+	"commentStamp" : "BF 6/19/2021 10:36",
 	"instvars" : [
 		 ],
-	"name" : "GHAConnectionError",
+	"name" : "ATDDNotFoundError",
 	"pools" : [
 		 ],
 	"super" : "Error",

diff --git a/packages/AutoTDD-Exceptions.package/GHAAccessDeniedError.class/README.md b/packages/AutoTDD-Exceptions.package/GHAAccessDeniedError.class/README.md
diff --git a/packages/AutoTDD-Exceptions.package/GHAAccessDeniedError.class/instance/defaultAction.st b/packages/AutoTDD-Exceptions.package/GHAAccessDeniedError.class/instance/defaultAction.st
diff --git a/packages/AutoTDD-Exceptions.package/GHAAccessDeniedError.class/methodProperties.json b/packages/AutoTDD-Exceptions.package/GHAAccessDeniedError.class/methodProperties.json
diff --git a/packages/AutoTDD-Exceptions.package/GHAConnectionError.class/README.md b/packages/AutoTDD-Exceptions.package/GHAConnectionError.class/README.md
diff --git a/packages/AutoTDD-Exceptions.package/GHAConnectionError.class/methodProperties.json b/packages/AutoTDD-Exceptions.package/GHAConnectionError.class/methodProperties.json
diff --git a/packages/AutoTDD-Exceptions.package/TCIAccessDeniedError.class/README.md b/packages/AutoTDD-Exceptions.package/TCIAccessDeniedError.class/README.md
diff --git a/packages/AutoTDD-Exceptions.package/TCIAccessDeniedError.class/class/accessDeniedMessage.st b/packages/AutoTDD-Exceptions.package/TCIAccessDeniedError.class/class/accessDeniedMessage.st
diff --git a/packages/AutoTDD-Exceptions.package/TCIAccessDeniedError.class/instance/defaultAction.st b/packages/AutoTDD-Exceptions.package/TCIAccessDeniedError.class/instance/defaultAction.st
diff --git a/packages/AutoTDD-Exceptions.package/TCIAccessDeniedError.class/methodProperties.json b/packages/AutoTDD-Exceptions.package/TCIAccessDeniedError.class/methodProperties.json
diff --git a/packages/AutoTDD-Exceptions.package/TCIConnectionError.class/README.md b/packages/AutoTDD-Exceptions.package/TCIConnectionError.class/README.md
diff --git a/packages/AutoTDD-Exceptions.package/TCIConnectionError.class/instance/defaultAction.st b/packages/AutoTDD-Exceptions.package/TCIConnectionError.class/instance/defaultAction.st
diff --git a/packages/AutoTDD-Exceptions.package/TCIConnectionError.class/methodProperties.json b/packages/AutoTDD-Exceptions.package/TCIConnectionError.class/methodProperties.json
diff --git a/packages/AutoTDD-Exceptions.package/TCIConnectionError.class/properties.json b/packages/AutoTDD-Exceptions.package/TCIConnectionError.class/properties.json
diff --git a/packages/AutoTDD-GUI.package/ATDDBrowser.class/instance/refreshGitHubAction..st b/packages/AutoTDD-GUI.package/ATDDBrowser.class/instance/refreshGitHubAction..st
@@ -1,4 +1,9 @@
 action
 refreshGitHubAction: aGitHubAction
 
-	aGitHubAction refresh
+	[ aGitHubAction refresh ] 
+		on: ATDDAccessDeniedError
+		do: [
+			UIManager default inform: ATDDAccessDeniedError rateLimitMessage.
+			self pauseTestingEntity: aGitHubAction
+		 ]
diff --git a/packages/AutoTDD-GUI.package/ATDDBrowser.class/instance/resumeGitHubAction..st b/packages/AutoTDD-GUI.package/ATDDBrowser.class/instance/resumeGitHubAction..st
@@ -1,4 +1,9 @@
 action
 resumeGitHubAction: aGitHubAction
 
-	aGitHubAction resume
+	[ aGitHubAction resume ] 
+		on: ATDDAccessDeniedError
+		do: [
+			UIManager default inform: ATDDAccessDeniedError rateLimitMessage.
+			self pauseTestingEntity: aGitHubAction
+		 ]
diff --git a/packages/AutoTDD-GUI.package/ATDDBrowser.class/methodProperties.json b/packages/AutoTDD-GUI.package/ATDDBrowser.class/methodProperties.json
@@ -79,7 +79,7 @@
 		"pauseTestingEntity:" : "sw 5/28/2021 15:17",
 		"pauseTravisStatuses" : "sw 5/26/2021 00:03",
 		"pauseWatchers" : "sw 5/26/2021 00:04",
-		"refreshGitHubAction:" : "sw 5/21/2021 21:01",
+		"refreshGitHubAction:" : "BF 6/18/2021 14:51",
 		"refreshSelectedGitHubActions" : "sw 5/21/2021 21:02",
 		"refreshSelectedTravisStatuses" : "swi 7/10/2019 14:03",
 		"refreshTravisStatus:" : "swi 7/10/2019 14:03",
@@ -93,7 +93,7 @@
 		"resultsTravisStatuses" : "sw 5/26/2021 00:07",
 		"resultsWatchers" : "sw 5/26/2021 00:07",
 		"resumeAll" : "sw 5/21/2021 21:05",
-		"resumeGitHubAction:" : "sw 5/21/2021 21:04",
+		"resumeGitHubAction:" : "BF 6/18/2021 14:51",
 		"resumeSelectedGitHubActions" : "sw 5/21/2021 22:17",
 		"resumeSelectedTravisStatuses" : "swi 7/25/2019 15:30",
 		"resumeSelectedWatchers" : "swi 7/25/2019 15:31",

diff --git a/packages/AutoTDD-GUI.package/ATDDGitHubActionEditor.class/instance/applyChanges.st b/packages/AutoTDD-GUI.package/ATDDGitHubActionEditor.class/instance/applyChanges.st
@@ -3,4 +3,6 @@ applyChanges
 
 	super applyChanges.
 
-	self gitHubAction resume
+	[ self gitHubAction resume ]
+		on: ATDDAccessDeniedError
+		do: [ self gitHubAction pause ]
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		An ATDDAccessDeniedError is thrown when the HTTP request results in a 403 (Forbidden) Error.
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		An ATDDConnectionError is thrown when the HTTP request results in a 401 (Unauthorized) Error.
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		An ATDDNotFoundError is thrown when the HTTP request results in a 404 (Not Found) Error.