Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Exception Handling #93

Merged
merged 5 commits into from
Jun 20, 2021
Merged

Improve Exception Handling #93

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e4eb268
starting exception handling again
kolioOtSofia Jun 18, 2021
4aa03bc
adding stuff
kolioOtSofia Jun 18, 2021
2de178a
Finish Exception Handling
Benjamin-Frost Jun 18, 2021
8156cb8
Small Improvements
Benjamin-Frost Jun 19, 2021
e5955e8
Recategorize
Benjamin-Frost Jun 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/AutoTDD-Core.package/ATDDGitHubAction.class/instance/pause.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
behaviour
pause

super pause.
ATDDBrowser changedGitHubActions
1 change: 1 addition & 0 deletions packages/AutoTDD-Core.package/ATDDGitHubAction.class/methodProperties.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
"symbol" : "sw 5/25/2021 22:27" },
"instance" : {
"initialize" : "BF 5/23/2021 21:18",
"pause" : "ng 6/18/2021 14:47",
"repositoryURL:" : "BF 5/23/2021 21:29",
"statusChanged" : "ClassTest 5/29/2021 19:31",
"updateStatus" : "ClassTest 5/28/2021 23:47" } }
4 changes: 0 additions & 4 deletions packages/AutoTDD-Core.package/ATDDGitHubActionsClient.class/instance/errorDictionary.st
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion packages/AutoTDD-Core.package/ATDDGitHubActionsClient.class/instance/requestOn..st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ requestOn: aString
response content; close ]
on: Error
do: [ :error |
[ GHAConnectionError signal: 'Connection failed: ' , error messageText ] fork.
[ ATDDConnectionError signal: 'Connection failed: ' , error messageText ] fork.
^ JsonObject new ].
^ response code
= 200
Expand Down
4 changes: 1 addition & 3 deletions packages/AutoTDD-Core.package/ATDDGitHubActionsClient.class/methodProperties.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,11 @@
"class" : {
},
"instance" : {
"errorDictionary" : "ng 5/26/2021 19:13",
"getJsonForJobsForRepository:forWorkflowRunId:" : "BF 5/23/2021 21:30",
"getJsonForLatestWorkflowRunForRepository:" : "ng 5/27/2021 19:07",
"getJsonForWorkflow:" : "ng 5/23/2021 12:08",
"getJsonForWorkflowRunsForRepository:" : "ng 5/22/2021 19:16",
"getLogsForRepository:logId:" : "ng 5/27/2021 19:07",
"gitHubActionsApiUrl" : "ng 5/14/2021 16:07",
"mimeType" : "ng 5/14/2021 15:45",
"requestOn:" : "BF 5/28/2021 21:36",
"throwExceptionForResponseCode:" : "ng 5/26/2021 19:14" } }
"requestOn:" : "ng 6/18/2021 14:04" } }
8 changes: 8 additions & 0 deletions packages/AutoTDD-Core.package/ATDDRemoteClient.class/instance/errorDictionary.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
accessing
errorDictionary

^ IdentityDictionary newFrom: {
401 -> ATDDConnectionError.
403 -> ATDDAccessDeniedError.
404 -> ATDDNotFoundError
}
0 ...nstance/throwExceptionForResponseCode..st → ...nstance/throwExceptionForResponseCode..st
View file
Open in desktop
File renamed without changes.
2 changes: 2 additions & 0 deletions packages/AutoTDD-Core.package/ATDDRemoteClient.class/methodProperties.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
"class" : {
},
"instance" : {
"errorDictionary" : "ng 6/18/2021 14:48",
"throwExceptionForResponseCode:" : "ng 6/18/2021 14:05",
"token" : "ClassTest 6/2/2021 18:44",
"token:" : "ClassTest 6/2/2021 18:44",
"userAgent" : "ClassTest 6/2/2021 18:45",
Expand Down
3 changes: 1 addition & 2 deletions packages/AutoTDD-Core.package/ATDDRemoteTestingEntity.class/instance/pause.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,4 @@ behaviour
pause

self terminateProcess.
super pause.
self updateStatus
super pause
2 changes: 1 addition & 1 deletion packages/AutoTDD-Core.package/ATDDRemoteTestingEntity.class/methodProperties.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"internalStatus" : "ClassTest 6/2/2021 17:54",
"internalStatus:" : "ClassTest 5/29/2021 19:42",
"newRefreshProcess" : "sw 5/28/2021 18:04",
"pause" : "sw 5/28/2021 18:04",
"pause" : "ng 6/18/2021 14:46",
"pausedString" : "sw 5/28/2021 18:04",
"process" : "sw 5/28/2021 18:06",
"process:" : "sw 5/28/2021 18:06",
Expand Down
4 changes: 0 additions & 4 deletions packages/AutoTDD-Core.package/ATDDTravisClient.class/instance/errorDictionary.st
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion packages/AutoTDD-Core.package/ATDDTravisClient.class/instance/requestOn..st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ requestOn: aString
response content; close ]
on: Error
do: [ :error |
[ TCIConnectionError signal: 'Connection failed: ' , error messageText ] fork.
[ ATDDConnectionError signal: 'Connection failed: ' , error messageText ] fork.
^ JsonObject new ].

^ response code
Expand Down
4 changes: 0 additions & 4 deletions ...es/AutoTDD-Core.package/ATDDTravisClient.class/instance/throwExceptionForResponseCode..st
View file
Open in desktop

This file was deleted.

4 changes: 1 addition & 3 deletions packages/AutoTDD-Core.package/ATDDTravisClient.class/methodProperties.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
"class" : {
},
"instance" : {
"errorDictionary" : "PS 7/25/2014 17:01",
"getJsonForBuild:" : "CW 2/25/2016 10:14",
"getJsonForBuildsOfRepository:" : "PS 5/19/2014 17:44",
"getJsonForJob:" : "PS 5/19/2014 14:40",
Expand All @@ -12,8 +11,7 @@
"isJson:" : "PS 6/11/2014 13:56",
"mimeType" : "PS 5/18/2014 18:04",
"requestAPIOn:" : "maf 12/5/2017 14:41",
"requestOn:" : "ls 7/25/2019 15:30",
"throwExceptionForResponseCode:" : "PS 6/23/2014 15:55",
"requestOn:" : "ng 6/18/2021 14:04",
"travisApiUrl" : "PS 6/19/2014 09:57",
"usePro" : "PS 6/19/2014 09:56",
"usePro:" : "ls 7/25/2019 15:20" } }
2 changes: 1 addition & 1 deletion packages/AutoTDD-Core.package/ATDDTravisRepository.class/instance/validate..st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
data-processing
validate: aString

(aString matchesRegex: self class validSlug) ifFalse: [ TCINoValidSlugError signal ]
(aString matchesRegex: self class validSlug) ifFalse: [ ATDDNoValidSlugError signal ]
2 changes: 1 addition & 1 deletion packages/AutoTDD-Core.package/ATDDTravisRepository.class/methodProperties.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,5 +29,5 @@
"update" : "ls 7/11/2019 18:57",
"usePro" : "ls 6/5/2019 21:10",
"usePro:" : "ls 7/25/2019 14:13",
"validate:" : "vxr 7/4/2019 14:25",
"validate:" : "ng 6/18/2021 14:06",
"wrapAsJson:" : "vxr 7/4/2019 14:25" } }
5 changes: 5 additions & 0 deletions packages/AutoTDD-Core.package/ATDDTravisStatus.class/instance/pause.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
behaviour
pause

super pause.
ATDDBrowser changedTravisStatuses
1 change: 1 addition & 0 deletions packages/AutoTDD-Core.package/ATDDTravisStatus.class/methodProperties.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
"symbol" : "sw 5/25/2021 22:21" },
"instance" : {
"initialize" : "BF 5/23/2021 21:18",
"pause" : "ng 6/18/2021 14:49",
"repositoryURL:" : "ls 7/25/2019 09:23",
"statusChanged" : "ClassTest 5/29/2021 19:36",
"updateStatus" : "ClassTest 5/28/2021 23:46",
Expand Down
1 change: 1 addition & 0 deletions packages/AutoTDD-Exceptions.package/ATDDAccessDeniedError.class/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
An ATDDAccessDeniedError is thrown when the HTTP request results in a 403 (Forbidden) Error.
2 changes: 1 addition & 1 deletion ...dError.class/class/accessDeniedMessage.st → ...DAccessDeniedError.class/class/message.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
accessing
accessDeniedMessage
message

^ 'Access denied'
4 changes: 4 additions & 0 deletions packages/AutoTDD-Exceptions.package/ATDDAccessDeniedError.class/class/rateLimitMessage.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
accessing
rateLimitMessage

^ 'You have been rate-limited. This GitHub Action will now be paused. Consider providing a token to prevent this.'
Benjamin-Frost marked this conversation as resolved.
Show resolved Hide resolved
4 changes: 4 additions & 0 deletions packages/AutoTDD-Exceptions.package/ATDDAccessDeniedError.class/instance/defaultAction.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
priv handling
defaultAction

^ Transcript show: self class message
6 changes: 6 additions & 0 deletions packages/AutoTDD-Exceptions.package/ATDDAccessDeniedError.class/methodProperties.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"class" : {
"message" : "ng 6/18/2021 13:55",
"rateLimitMessage" : "BF 6/18/2021 14:51" },
"instance" : {
"defaultAction" : "ng 6/18/2021 13:53" } }
4 changes: 2 additions & 2 deletions ...HAAccessDeniedError.class/properties.json → ...DDAccessDeniedError.class/properties.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,10 @@
],
"classvars" : [
],
"commentStamp" : "ng 5/28/2021 14:44",
"commentStamp" : "BF 6/19/2021 10:35",
"instvars" : [
],
"name" : "GHAAccessDeniedError",
"name" : "ATDDAccessDeniedError",
"pools" : [
],
"super" : "Error",
Expand Down
1 change: 1 addition & 0 deletions packages/AutoTDD-Exceptions.package/ATDDConnectionError.class/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
An ATDDConnectionError is thrown when the HTTP request results in a 401 (Unauthorized) Error.
0 ...tionError.class/instance/defaultAction.st → ...tionError.class/instance/defaultAction.st
View file
Open in desktop
File renamed without changes.
5 changes: 5 additions & 0 deletions packages/AutoTDD-Exceptions.package/ATDDConnectionError.class/methodProperties.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"class" : {
},
"instance" : {
"defaultAction" : "ng 6/18/2021 14:03" } }
4 changes: 2 additions & 2 deletions ...TCINoValidSlugError.class/properties.json → ...ATDDConnectionError.class/properties.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,10 @@
],
"classvars" : [
],
"commentStamp" : "be 7/25/2019 10:29",
"commentStamp" : "BF 6/19/2021 10:35",
"instvars" : [
],
"name" : "TCINoValidSlugError",
"name" : "ATDDConnectionError",
"pools" : [
],
"super" : "Error",
Expand Down
0 ...ckage/TCINoValidSlugError.class/README.md → ...kage/ATDDNoValidSlugError.class/README.md
View file
Open in desktop
File renamed without changes.
0 ...ugError.class/class/noValidSlugMessage.st → ...ugError.class/class/noValidSlugMessage.st
View file
Open in desktop
File renamed without changes.
0 ...SlugError.class/instance/defaultAction.st → ...SlugError.class/instance/defaultAction.st
View file
Open in desktop
File renamed without changes.
0 ...alidSlugError.class/methodProperties.json → ...alidSlugError.class/methodProperties.json
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion ...CIAccessDeniedError.class/properties.json → ...TDDNoValidSlugError.class/properties.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"commentStamp" : "be 7/25/2019 10:29",
"instvars" : [
],
"name" : "TCIAccessDeniedError",
"name" : "ATDDNoValidSlugError",
"pools" : [
],
"super" : "Error",
Expand Down
1 change: 1 addition & 0 deletions packages/AutoTDD-Exceptions.package/ATDDNotFoundError.class/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
An ATDDNotFoundError is thrown when the HTTP request results in a 404 (Not Found) Error.
4 changes: 4 additions & 0 deletions packages/AutoTDD-Exceptions.package/ATDDNotFoundError.class/class/message.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
accessing
message

^ 'Not Found'
4 changes: 4 additions & 0 deletions packages/AutoTDD-Exceptions.package/ATDDNotFoundError.class/instance/defaultAction.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
priv handling
defaultAction

^ Transcript show: self class message
5 changes: 5 additions & 0 deletions packages/AutoTDD-Exceptions.package/ATDDNotFoundError.class/methodProperties.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"class" : {
"message" : "ng 6/18/2021 13:55" },
"instance" : {
"defaultAction" : "ng 6/18/2021 13:59" } }
4 changes: 2 additions & 2 deletions .../GHAConnectionError.class/properties.json → ...e/ATDDNotFoundError.class/properties.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,10 @@
],
"classvars" : [
],
"commentStamp" : "ng 5/28/2021 14:45",
"commentStamp" : "BF 6/19/2021 10:36",
"instvars" : [
],
"name" : "GHAConnectionError",
"name" : "ATDDNotFoundError",
"pools" : [
],
"super" : "Error",
Expand Down
1 change: 0 additions & 1 deletion packages/AutoTDD-Exceptions.package/GHAAccessDeniedError.class/README.md
View file
Open in desktop

This file was deleted.

4 changes: 0 additions & 4 deletions packages/AutoTDD-Exceptions.package/GHAAccessDeniedError.class/instance/defaultAction.st
View file
Open in desktop

This file was deleted.

5 changes: 0 additions & 5 deletions packages/AutoTDD-Exceptions.package/GHAAccessDeniedError.class/methodProperties.json
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion packages/AutoTDD-Exceptions.package/GHAConnectionError.class/README.md
View file
Open in desktop

This file was deleted.

5 changes: 0 additions & 5 deletions packages/AutoTDD-Exceptions.package/GHAConnectionError.class/methodProperties.json
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion packages/AutoTDD-Exceptions.package/TCIAccessDeniedError.class/README.md
View file
Open in desktop

This file was deleted.

4 changes: 0 additions & 4 deletions packages/AutoTDD-Exceptions.package/TCIAccessDeniedError.class/class/accessDeniedMessage.st
View file
Open in desktop

This file was deleted.

4 changes: 0 additions & 4 deletions packages/AutoTDD-Exceptions.package/TCIAccessDeniedError.class/instance/defaultAction.st
View file
Open in desktop

This file was deleted.

5 changes: 0 additions & 5 deletions packages/AutoTDD-Exceptions.package/TCIAccessDeniedError.class/methodProperties.json
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion packages/AutoTDD-Exceptions.package/TCIConnectionError.class/README.md
View file
Open in desktop

This file was deleted.

5 changes: 0 additions & 5 deletions packages/AutoTDD-Exceptions.package/TCIConnectionError.class/instance/defaultAction.st
View file
Open in desktop

This file was deleted.

5 changes: 0 additions & 5 deletions packages/AutoTDD-Exceptions.package/TCIConnectionError.class/methodProperties.json
View file
Open in desktop

This file was deleted.

14 changes: 0 additions & 14 deletions packages/AutoTDD-Exceptions.package/TCIConnectionError.class/properties.json
View file
Open in desktop

This file was deleted.

7 changes: 6 additions & 1 deletion packages/AutoTDD-GUI.package/ATDDBrowser.class/instance/refreshGitHubAction..st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,9 @@
action
refreshGitHubAction: aGitHubAction

aGitHubAction refresh
[ aGitHubAction refresh ]
on: ATDDAccessDeniedError
do: [
UIManager default inform: ATDDAccessDeniedError rateLimitMessage.
self pauseTestingEntity: aGitHubAction
]
7 changes: 6 additions & 1 deletion packages/AutoTDD-GUI.package/ATDDBrowser.class/instance/resumeGitHubAction..st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,9 @@
action
resumeGitHubAction: aGitHubAction

aGitHubAction resume
[ aGitHubAction resume ]
on: ATDDAccessDeniedError
do: [
UIManager default inform: ATDDAccessDeniedError rateLimitMessage.
self pauseTestingEntity: aGitHubAction
]
4 changes: 2 additions & 2 deletions packages/AutoTDD-GUI.package/ATDDBrowser.class/methodProperties.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@
"pauseTestingEntity:" : "sw 5/28/2021 15:17",
"pauseTravisStatuses" : "sw 5/26/2021 00:03",
"pauseWatchers" : "sw 5/26/2021 00:04",
"refreshGitHubAction:" : "sw 5/21/2021 21:01",
"refreshGitHubAction:" : "BF 6/18/2021 14:51",
"refreshSelectedGitHubActions" : "sw 5/21/2021 21:02",
"refreshSelectedTravisStatuses" : "swi 7/10/2019 14:03",
"refreshTravisStatus:" : "swi 7/10/2019 14:03",
Expand All @@ -93,7 +93,7 @@
"resultsTravisStatuses" : "sw 5/26/2021 00:07",
"resultsWatchers" : "sw 5/26/2021 00:07",
"resumeAll" : "sw 5/21/2021 21:05",
"resumeGitHubAction:" : "sw 5/21/2021 21:04",
"resumeGitHubAction:" : "BF 6/18/2021 14:51",
"resumeSelectedGitHubActions" : "sw 5/21/2021 22:17",
"resumeSelectedTravisStatuses" : "swi 7/25/2019 15:30",
"resumeSelectedWatchers" : "swi 7/25/2019 15:31",
Expand Down
4 changes: 3 additions & 1 deletion packages/AutoTDD-GUI.package/ATDDGitHubActionEditor.class/instance/applyChanges.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,6 @@ applyChanges

super applyChanges.

self gitHubAction resume
[ self gitHubAction resume ]
on: ATDDAccessDeniedError
do: [ self gitHubAction pause ]
Loading