-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate name property of unit system #80257
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
homeassistant
added
breaking-change
cla-signed
core
deprecation
Indicates a breaking change to happen in the future
Hacktoberfest
small-pr
PRs with less than 30 lines.
labels
Oct 13, 2022
epenet
changed the title
Deprecate unit_system name
Deprecate name property of unit system
Oct 13, 2022
epenet
force-pushed
the
deprecate-unit-system-name
branch
from
October 13, 2022 15:36
57c1dc5
to
b960975
Compare
This was referenced Oct 13, 2022
emontnemery
approved these changes
Oct 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
emontnemery
added
the
second-opinion-wanted
Add this label when a reviewer needs a second opinion from another member.
label
Oct 14, 2022
epenet
commented
Oct 14, 2022
frenck
approved these changes
Oct 14, 2022
emontnemery
removed
the
second-opinion-wanted
Add this label when a reviewer needs a second opinion from another member.
label
Oct 14, 2022
8 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
cla-signed
core
deprecation
Indicates a breaking change to happen in the future
Hacktoberfest
small-pr
PRs with less than 30 lines.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
The name of a unit system should never be used for checking its type. Instance checks should be used instead:
Correct:
Incorrect:
Proposed change
Deprecate the
name
property, and log a warning if it is accessed.Linked PRs:
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: