Adjust distance unit check in geonetnz_volcano #80244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
homeassistant
added
cla-signed
code-quality
Hacktoberfest
integration: geonetnz_volcano
small-pr
|
Hey there @exxamalte, mind taking a look at this pull request as it has been labeled with an integration ( |
epenet
commented
Oct 13, 2022
| @@ -57,7 +58,7 @@ async def async_step_user(self, user_input=None): | |||
| if identifier in configured_instances(self.hass): | |||
| return await self._show_form({"base": "already_configured"}) | |||
|
|
|||
| if self.hass.config.units.name == CONF_UNIT_SYSTEM_IMPERIAL: | |||
| if self.hass.config.units.length_unit == LENGTH_MILES: | |||
There was a problem hiding this comment.
Checking/Storing the name of the unit system will stop working if we rename or add a new unit system.
It is more future-proof to check the length_unit of the unit system, even if the component still uses "imperial" terminology.
There was a problem hiding this comment.
Adjusted to use hass.config.units == ***
31 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Adjust distance unit check in geonetnz_volcano
Linked to #80257
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: