Adjust get_distance_unit in mazda integration #80233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
homeassistant
added
cla-signed
code-quality
Hacktoberfest
integration: mazda
small-pr
|
Hey there @bdr99, mind taking a look at this pull request as it has been labeled with an integration ( |
epenet
commented
Oct 13, 2022
Comment on lines
47
to
49
| def _get_distance_unit(unit_system: UnitSystem) -> str: | ||
| """Return the distance unit for the given unit system.""" | ||
| if unit_system.name == CONF_UNIT_SYSTEM_IMPERIAL: | ||
| return LENGTH_MILES | ||
| return LENGTH_KILOMETERS | ||
| return unit_system.length_unit |
There was a problem hiding this comment.
The integration is currently using unit_system.length on the value functions, regardless of the unit system name.
This adjusts the unit_of_measurement function to match that behavior.
There was a problem hiding this comment.
Adjusted to use hass.config.units == *** and DistanceConverter
31 tasks
emontnemery
approved these changes
Oct 14, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Adjust
get_distance_unitin mazda integrationLinked to #80257
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: