Issue 6749 updated pylgtv to 0.1.6 to fix thread leak in asyncio loop #7199
Conversation
* dev: mvglive bug fixes and improvements (#6953) Do not request artwork if not available (#7189) Fix auto discovery for Apple TV (#7188) Fix for errors on missing preview on LG webos TV (#6755) Added light.pwm component. (#7009) Add ping binary sensor (#7052) opensky sensor (#7061) JSON MQTT Device tracker (#7055) spotify media player (#6980) Update frontend Add Bose soundtouch discovery support and upgrade libsoundtouch library (#7005) Fix wemo discovery (#7183) updated pylgtv module to fix problems with timeouts (#7184) Mqtt camera test (#7175) Update frontend
- handle new TimeoutError exception from pylgtv
|
@hmn, thanks for your PR! By analyzing the history of the files in this pull request, we identified @armills, @TheRealLink and @andersonshatch to be potential reviewers. |
* dev: (37 commits) HassIO API v2 (#7201) LIFX light effects (#7145) Add HassIO to discovery component (#7195) Add support of input registers while querying modbus sensor. (#7082) Upgrade py-cpuinfo to 3.2.0 (#7190) Fix for zwave RGB setting (#7137) Make version number optional and a string to fix identify issue introduced in iOS 1.0.1 (#7141) Upgrade aiohttp to 2.0.7 (#7106) Fix mysensors callback (#7057) Version bump to 0.42.4 Bugfix slider (#7047) Bugfix wait on start event (#7013) Plug file leak on LIFX unregister (#7031) Fix US states check (fixes #7015) (#7017) Bump pyalarmdotcom to support new version of aiohttp (#7021) Fix two more instances of JSON parsing synology (#7014) Fix Synology camera content type (#7010) Version bump to 0.42.3 Downgrade aiohttp to 205 (#6994) version bump to 0.42.2 ...
| @@ -257,7 +258,7 @@ def turn_off(self): | |||
| self._state = STATE_OFF | |||
| try: | |||
| self._client.power_off() | |||
| except (OSError, ConnectionClosed): | |||
| except (OSError, ConnectionClosed, concurrent.futures._base.TimeoutError): | |||
There was a problem hiding this comment.
line too long (82 > 79 characters)
| @@ -196,7 +197,7 @@ def update(self): | |||
| app = self._app_list[source['appId']] | |||
| self._source_list[app['title']] = app | |||
|
|
|||
| except (OSError, ConnectionClosed): | |||
| except (OSError, ConnectionClosed, concurrent.futures._base.TimeoutError): | |||
There was a problem hiding this comment.
line too long (82 > 79 characters)
| @@ -99,7 +100,7 @@ def setup_tv(host, mac, name, customize, config, hass, add_devices): | |||
| _LOGGER.warning( | |||
| "Connected to LG webOS TV %s but not paired", host) | |||
| return | |||
| except (OSError, ConnectionClosed): | |||
| except (OSError, ConnectionClosed, concurrent.futures._base.TimeoutError): | |||
There was a problem hiding this comment.
line too long (86 > 79 characters)
| @@ -87,6 +87,7 @@ def setup_tv(host, mac, name, customize, config, hass, add_devices): | |||
| from pylgtv import WebOsClient | |||
| from pylgtv import PyLGTVPairException | |||
| from websockets.exceptions import ConnectionClosed | |||
| from concurrent import futures | |||
There was a problem hiding this comment.
Instead of this, import asyncio at the top of the module, and use asyncio.TimeoutError. It's an alias for concurrent.futures.TimeoutError.
There was a problem hiding this comment.
ok thanks, I had a bit a problem figuring out what the right way to do this was
| @@ -217,7 +221,7 @@ def is_volume_muted(self): | |||
| @property | |||
| def volume_level(self): | |||
| """Volume level of the media player (0..1).""" | |||
| return self._volume / 100.0 | |||
| return float(self._volume) / 100.0 | |||
There was a problem hiding this comment.
This shouldn't be necessary. Dividing by a float will perform the conversion automatically.
|
the requested changes should be done now sorry for the messy pull request i'll do better next time :) |
|
Cherry-picked into 0.43 |
…#7199) * updated pylgtv module to fix problems with timeouts * - update pylgtv to 0.1.6 - handle new TimeoutError exception from pylgtv * used full name for exception handling of concurrent.futures._base.TimeoutError * the exception handling should now follow the rules * float typecasting should not be necessary * use asyncio for TimeoutError it’s an alias for concurrent.futures.TimeoutError
|
It's no problem! The stacktrace prints the reference to concurrent.futures, so you basically just have to know the alias is there in asyncio. We appreciate the contribution! |
ghost
removed
the
Description:
updated pylgtv to 0.1.6 to fix thread leak in asyncio loop
Related issue (if applicable): fixes #6749
Checklist:
If the code communicates with devices, web services, or third-party tools:
toxrun successfully. Your PR cannot be merged unless tests passREQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py.