Fix for errors on missing preview on LG webos TV

[masarliev]

Description:

largeIcon property on my TV and I guess other versions is file path. That's why it can not be requested as HTTP URI. I changed it to icon property that is the icon of current playing source.

Related issue (if applicable): fixes #5113

[mention-bot]

@masarliev, thanks for your PR! By analyzing the history of the files in this pull request, we identified @TheRealLink, @trisk and @fabaff to be potential reviewers.

[andrey-git]

@masarliev Could you explain the issue with largeIcon?
It was specifically changed in #2561 by @roidayan

[andrey-git]

OK, I see details in the linked issue.
What is the value of self._app_list[self._current_source_id]['icon'] ?

[masarliev]

I don't remember exact value but is something like http://ip-address:port/path/to/icon.png
and this icon is current active source

[roidayan]

Maybe it depends on webos version
Icon is so small it looked bad in the ui than using large icon.
Maybe should use large icon if possible or fallback to icon.
Large icon should be accessible from URL may e your webos version just missing the http URL prefix?
Can you show large icon and icon strings together ?
I'll check it as well later when I can.

[roidayan]

I looked in the paths in the issue. so it looks like it depends in the webos version. the issue specify webos v1.4 while in my webos v2 both icon and largeIcon are urls.

'icon': 'http://192.168.31.64:3000/resources/09216e4e921f2209fe0749fbbf99952236fd032e/icon.png',
'largeIcon': 'http://192.168.31.64:3000/resources/27f9d4b79b9d1caf3530f1d8cd25cfa79591e19c/livetv_130x130.png'

bummer. I guess we need to use icon (or use largeIcon if it's url and fallback to icon if not)

[roidayan]

in webos v2 largeIcon is a url and looks better so I suggest maybe check if largeIcon is not a url fallback to icon?

e.g.

if self._current_source_id in self._app_list:
  icon = self._app_list[self._current_source_id]['largeIcon']
  if not icon.startswith('http'):
    icon = self._app_list[self._current_source_id]['icon']
  return icon
return None

any thoughts?

[masarliev]

LGTM. I will change like this

[roidayan]

LGTM. the 2 commits could be squashed into 1 in my opinion.

[balloob]

I have a squash and merge button @roidayan 👍