spotify media player

[happyleavesaoc]

Description:

Spotify recently opened up their "Connect" playback web api: https://developer.spotify.com/web-api/web-api-connect-endpoint-reference/

Now we can have a Spotify media player with standard playback controls, track metadata, etc. Also can switch devices (implemented via source_select).

Pending spotipy-dev/spotipy#182 on the spotipy library; temporarily depending on my fork.

Requirements:

• Spotify Premium account
• Spotify developer "Application" created: https://developer.spotify.com/my-applications/#!/applications
• Client ID and secret from Application
• Set Application redirect URI to http://<your_url>/api/spotify

I hope someone else can test this before it is merged.

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#2406

Example entry for configuration.yaml (if applicable):

media_player:
  - platform: spotify
    client_id: !secret spotify_client_id
    client_secret: !secret spotify_client_secret

Checklist:

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated in home-assistant.github.io

If the code communicates with devices, web services, or third-party tools:

• Local tests with tox run successfully. Your PR cannot be merged unless tests pass
• New dependencies have been added to the REQUIREMENTS variable ([example][ex-requir]).
• New dependencies are only imported inside functions that use them ([example][ex-import]).
• New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
• New files were added to .coveragerc.
  [ex-requir]: https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/keyboard.py#L14
  [ex-import]: https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/keyboard.py#L54

[mention-bot]

@happyleavesaoc, thanks for your PR! By analyzing the history of the files in this pull request, we identified @balloob, @fabaff and @robbiet480 to be potential reviewers.

[houndci-bot]

continuation line under-indented for visual indent

[houndci-bot]

undefined name 'STATE_IDLE'

[houndci-bot]

undefined name 'STATE_IDLE'

[happyleavesaoc]

A few users have tested this and confirmed it works. Ready to merge!

[robbiet480]

This worked for me, although the redirect caused a file download in my browser. I believe it's because Spotify expects to POST back to /api/spotify but you only accept GETs.

Other than that very small note, everything seems to work!

[happyleavesaoc]

@robbiet480 POST results in 405: Method Not Allowed since oauth sends a GET, I guess. I haven't been able to find any documentation on what HTTP verb and/or headers are required to not cause a file download in this case.

[balloob]

Sorry for taking so long to review. I've been busy.

I removed the calls to schedule_update_ha_state, your device does not overwrite should_poll and thus the default value True is active. When a device should be polled, Home Assistant will automatically call update after it calls a service.

This looks good 🐬

[pbros]

Hello, I tried using this media player, but I get the following error :

File "/usr/local/lib/python3.5/dist-packages/homeassistant/components/media_player/spotify.py", line 156, in update
self.refresh_spotify_instance()
File "/usr/local/lib/python3.5/dist-packages/homeassistant/components/media_player/spotify.py", line 143, in refresh_spotify_instance
self._oauth.is_token_expired(self._token_info))
AttributeError: 'SpotifyOAuth' object has no attribute 'is_token_expired'

[happyleavesaoc]

@pbros Make sure you've installed the correct version of spotipy. For future questions, please open an issue, post on the community forum, or visit us on gitter.