Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Bump aiohttp-zlib-ng to 0.2.0 (#106691)" #107109

Merged
merged 1 commit into from
Jan 4, 2024
Merged

Revert "Bump aiohttp-zlib-ng to 0.2.0 (#106691)" #107109

merged 1 commit into from
Jan 4, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Jan 4, 2024

This reverts commit e1f078b.

Our i386 builder runs on an x86_64 system and tries to match x86_64 packages. My attempt at fixing it in home-assistant/builder#189 didn't solve the issue, and since this is blocking nightly from building, revert the change.

the intel isal lib only provides the acceleration on aarch64/x86_64 (which covers the majority of our install base) so there are markers to only install it on those https://github.com/bdraco/aiohttp-zlib-ng/blob/a82a022e9270fa75c3ac2a08620365ff841f4e4e/pyproject.toml#L28. It works fine on the wheel builder because it sees i386 as i386 because of linux32. For the image builds I think it trying to install the dep because sees the platform_machine as x86_64 but pip knows it wants i686 wheels so it tries to find the wheel for i686 which isn't there.

  • This probably also explains the problems with had with i686 and sqlalchemy in the past so it would be nice to come up with a solution. Their solution was to drop all the platform markers and move to extras if I recall correctly.

@home-assistant
Copy link

home-assistant bot commented Jan 4, 2024

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (http) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of http can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign http Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@frenck frenck merged commit 40d034c into dev Jan 4, 2024
53 checks passed
@frenck frenck deleted the zlib_revert branch January 4, 2024 14:34
bdraco added a commit that referenced this pull request Jan 4, 2024
@bdraco bdraco mentioned this pull request Jan 4, 2024
20 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Jan 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants