Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump aiohttp-zlib-ng to 0.2.0 #106691

Merged
merged 8 commits into from
Jan 2, 2024
Merged

Bump aiohttp-zlib-ng to 0.2.0 #106691

merged 8 commits into from
Jan 2, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Dec 29, 2023

wheels built successfully and are on wheels

Proposed change

changelog: bdraco/aiohttp-zlib-ng@v0.1.3...v0.2.0

isal is used if available on the platform which uses nasm

The eventual goal is that this will be upstreamed into aiohttp speedups

The compression speed is quite incredible as it's nearly as fast as decompression now and about 5x faster than base zlib. Since compression IS the current bottleneck for sending websocket messages, this helps quite a bit reducing frontend change latency.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (http) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of http can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign http Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@bdraco
Copy link
Member Author

bdraco commented Dec 30, 2023

this one is blocked since wheel builds are broken

trying to fix it in #106694

@bdraco bdraco marked this pull request as ready for review December 30, 2023 20:53
@bdraco bdraco requested a review from a team as a code owner December 30, 2023 20:53
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see what it does.

Thanks, @bdraco 👍

../Frenck

@frenck frenck merged commit e1f078b into dev Jan 2, 2024
73 of 74 checks passed
@frenck frenck deleted the aiohttp_zlib branch January 2, 2024 19:50
@bdraco
Copy link
Member Author

bdraco commented Jan 2, 2024

thanks

@bdraco
Copy link
Member Author

bdraco commented Jan 3, 2024

It looks like the build failed on i386 but the wheels were ok.

I think its because the image builds don't do this

https://github.com/home-assistant/wheels/blob/6a18828c159faf31114eb1bf4b2ffae30d7fbc66/rootfs/bin/run-builder.sh#L5

@bdraco
Copy link
Member Author

bdraco commented Jan 3, 2024

@bdraco
Copy link
Member Author

bdraco commented Jan 3, 2024

@github-actions github-actions bot locked and limited conversation to collaborators Jan 4, 2024
@home-assistant home-assistant unlocked this conversation Jan 4, 2024
bdraco added a commit that referenced this pull request Jan 4, 2024
bdraco added a commit that referenced this pull request Jan 4, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jan 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants