-
-
Notifications
You must be signed in to change notification settings - Fork 32k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump aiohttp-zlib-ng to 0.2.0 #106691
Bump aiohttp-zlib-ng to 0.2.0 #106691
Conversation
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
5.0.0 is failing to build on 32 bit systems https://bugs.launchpad.net/lxml/+bug/2047718
this one is blocked since wheel builds are broken trying to fix it in #106694 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks |
It looks like the build failed on i386 but the wheels were ok. I think its because the image builds don't do this |
The masking is missing in the images workflow https://github.com/home-assistant/builder/blob/50262a60dd1ac572535b8c1cf4db30706867a65d/builder.sh#L258 |
wheels built successfully and are on wheelsProposed change
changelog: bdraco/aiohttp-zlib-ng@v0.1.3...v0.2.0
isal is used if available on the platform which uses nasm
The eventual goal is that this will be upstreamed into aiohttp speedups
The compression speed is quite incredible as it's nearly as fast as decompression now and about 5x faster than base zlib. Since compression IS the current bottleneck for sending websocket messages, this helps quite a bit reducing frontend change latency.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: