Fix i386 builds reporting x86_64 in the build process #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 tasks
|
I'm pretty sure this will solve the issue but I don't have a good way to test it on my local arm system |
|
This change will not harm, so let's try |
frenck
approved these changes
Jan 3, 2024
|
I guess we need to do a release of this one and bump it in core to fix nightly. I've never done a release on this repo before so I'm not sure if there is anything more involved that marking the draft as the latest release in github so I've refrained from hitting the button to ensure I don't break anything. |
|
I will pick up, didn't do yesterday because of the main release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Image builds failed on i386 because the builder tried to install the x86_64 package which doesn't exist on i386 https://github.com/home-assistant/core/actions/runs/7392726377/job/20111619276 because python saw the arch as x86_64 instead of i386
The wheel builder is able to handle this case so the goal is to match https://github.com/home-assistant/wheels/blob/6a18828c159faf31114eb1bf4b2ffae30d7fbc66/rootfs/bin/run-builder.sh#L5