Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes 4 #834

Merged
merged 167 commits into from
May 30, 2023
Merged

Changes 4 #834

merged 167 commits into from
May 30, 2023

Conversation

alexvpickering
Copy link
Contributor

@alexvpickering alexvpickering commented May 15, 2023

Description

Details

URL to issue

N/A

Link to staging deployment URL (or set N/A)

N/A

Links to any PRs or resources related to this PR

#834
hms-dbmi-cellenics/api#433
hms-dbmi-cellenics/pipeline#302
hms-dbmi-cellenics/worker#304

Integration test branch

master

Merge checklist

Your changes will be ready for merging after all of the steps below have been completed.

Code updates

Have best practices and ongoing refactors being observed in this PR

  • Migrated any selector / reducer used to the new format.
  • All new dependency licenses have been checked for compatibility.

Manual/unit testing

  • Tested changes using InfraMock locally or no tests required for change, e.g. Kubernetes chart updates.
  • Validated that current unit tests for code work as expected and are sufficient for code coverage or no unit tests required for change, e.g. documentation update.
  • Unit tests written or no unit tests required for change, e.g. documentation update.

Integration testing

You must check the box below to run integration tests on the latest commit on your PR branch.
Integration tests have to pass before the PR can be merged. Without checking the box, your PR
will not pass the required status checks for merging.

  • Started end-to-end tests on the latest commit.

Documentation updates

  • Relevant Github READMEs updated or no GitHub README updates required.
  • Relevant Wiki pages created/updated or no Wiki updates required.

Optional

  • Staging environment is unstaged before merging.
  • Photo of a cute animal attached to this PR.

@github-actions
Copy link
Contributor

📦 Next.js Bundle Analysis for ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 599.26 KB (🟡 +1.15 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

New Page Added

The following page was added to the bundle from the code in this PR:

Page Size (compressed) First Load
/experiments/[experimentId]/plots-and-tables/batch-differential-expression 80.56 KB 679.83 KB

Fifteen Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/data-management 252.29 KB (🟡 +701 B) 851.55 KB
/experiments/[experimentId]/data-exploration 615.89 KB (🟢 -3.26 KB) 1.19 MB
/experiments/[experimentId]/data-processing 562.45 KB (🟢 -163 B) 1.13 MB
/experiments/[experimentId]/plots-and-tables 15.45 KB (🟡 +76 B) 614.71 KB
/experiments/[experimentId]/plots-and-tables/dot-plot 574.15 KB (🟢 -1.06 KB) 1.15 MB
/experiments/[experimentId]/plots-and-tables/embedding-categorical 519.63 KB (🟢 -754 B) 1.09 MB
/experiments/[experimentId]/plots-and-tables/embedding-continuous 567.67 KB (🟢 -923 B) 1.14 MB
/experiments/[experimentId]/plots-and-tables/frequency 516.99 KB (🟢 -2.16 KB) 1.09 MB
/experiments/[experimentId]/plots-and-tables/marker-heatmap 671.3 KB (🟢 -3.62 KB) 1.24 MB
/experiments/[experimentId]/plots-and-tables/normalized-matrix 181.58 KB (🟢 -3.53 KB) 780.84 KB
/experiments/[experimentId]/plots-and-tables/trajectory-analysis 523.37 KB (🟢 -378 B) 1.1 MB
/experiments/[experimentId]/plots-and-tables/violin 597.22 KB (🟢 -520 B) 1.17 MB
/experiments/[experimentId]/plots-and-tables/volcano 524.17 KB (🟡 +46 B) 1.1 MB
/repository 103.26 KB (🟢 -85 B) 702.53 KB
/settings/profile 30.19 KB (🟡 +316 B) 629.45 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@github-actions
Copy link
Contributor

📦 Next.js Bundle Analysis for ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 599.26 KB (🟡 +1.15 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

New Page Added

The following page was added to the bundle from the code in this PR:

Page Size (compressed) First Load
/experiments/[experimentId]/plots-and-tables/batch-differential-expression 80.56 KB 679.83 KB

Fifteen Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/data-management 252.3 KB (🟡 +711 B) 851.56 KB
/experiments/[experimentId]/data-exploration 615.89 KB (🟢 -3.26 KB) 1.19 MB
/experiments/[experimentId]/data-processing 562.45 KB (🟢 -163 B) 1.13 MB
/experiments/[experimentId]/plots-and-tables 15.45 KB (🟡 +76 B) 614.71 KB
/experiments/[experimentId]/plots-and-tables/dot-plot 574.15 KB (🟢 -1.06 KB) 1.15 MB
/experiments/[experimentId]/plots-and-tables/embedding-categorical 519.63 KB (🟢 -754 B) 1.09 MB
/experiments/[experimentId]/plots-and-tables/embedding-continuous 567.67 KB (🟢 -923 B) 1.14 MB
/experiments/[experimentId]/plots-and-tables/frequency 516.99 KB (🟢 -2.16 KB) 1.09 MB
/experiments/[experimentId]/plots-and-tables/marker-heatmap 671.3 KB (🟢 -3.62 KB) 1.24 MB
/experiments/[experimentId]/plots-and-tables/normalized-matrix 181.58 KB (🟢 -3.53 KB) 780.84 KB
/experiments/[experimentId]/plots-and-tables/trajectory-analysis 523.38 KB (🟢 -369 B) 1.1 MB
/experiments/[experimentId]/plots-and-tables/violin 597.22 KB (🟢 -520 B) 1.17 MB
/experiments/[experimentId]/plots-and-tables/volcano 524.17 KB (🟡 +46 B) 1.1 MB
/repository 103.26 KB (🟢 -85 B) 702.53 KB
/settings/profile 30.19 KB (🟡 +316 B) 629.45 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Signed-off-by: Alex Pickering <[email protected]>
@github-actions
Copy link
Contributor

📦 Next.js Bundle Analysis for ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 599.26 KB (🟡 +1.15 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

New Page Added

The following page was added to the bundle from the code in this PR:

Page Size (compressed) First Load
/experiments/[experimentId]/plots-and-tables/batch-differential-expression 80.56 KB 679.83 KB

Fifteen Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/data-management 252.3 KB (🟡 +711 B) 851.56 KB
/experiments/[experimentId]/data-exploration 615.89 KB (🟢 -3.26 KB) 1.19 MB
/experiments/[experimentId]/data-processing 562.45 KB (🟢 -163 B) 1.13 MB
/experiments/[experimentId]/plots-and-tables 15.45 KB (🟡 +76 B) 614.71 KB
/experiments/[experimentId]/plots-and-tables/dot-plot 574.15 KB (🟢 -1.06 KB) 1.15 MB
/experiments/[experimentId]/plots-and-tables/embedding-categorical 519.63 KB (🟢 -754 B) 1.09 MB
/experiments/[experimentId]/plots-and-tables/embedding-continuous 567.67 KB (🟢 -923 B) 1.14 MB
/experiments/[experimentId]/plots-and-tables/frequency 516.99 KB (🟢 -2.16 KB) 1.09 MB
/experiments/[experimentId]/plots-and-tables/marker-heatmap 671.3 KB (🟢 -3.62 KB) 1.24 MB
/experiments/[experimentId]/plots-and-tables/normalized-matrix 181.58 KB (🟢 -3.53 KB) 780.84 KB
/experiments/[experimentId]/plots-and-tables/trajectory-analysis 523.38 KB (🟢 -369 B) 1.1 MB
/experiments/[experimentId]/plots-and-tables/violin 597.22 KB (🟢 -520 B) 1.17 MB
/experiments/[experimentId]/plots-and-tables/volcano 524.17 KB (🟡 +46 B) 1.1 MB
/repository 103.26 KB (🟢 -85 B) 702.53 KB
/settings/profile 30.19 KB (🟡 +316 B) 629.45 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@codecov
Copy link

codecov bot commented May 15, 2023

Codecov Report

Merging #834 (d2e9d30) into master (00fc0b8) will decrease coverage by 0.10%.
The diff coverage is 84.05%.

❗ Current head d2e9d30 differs from pull request most recent head bd10b4b. Consider uploading reports for the commit bd10b4b to get more accurate results

@@            Coverage Diff             @@
##           master     #834      +/-   ##
==========================================
- Coverage   86.17%   86.08%   -0.10%     
==========================================
  Files         533      540       +7     
  Lines        9811     9986     +175     
  Branches     2063     2108      +45     
==========================================
+ Hits         8455     8596     +141     
- Misses       1312     1343      +31     
- Partials       44       47       +3     
Impacted Files Coverage Δ
...ial-expression-tool/LaunchPathwayAnalysisModal.jsx 100.00% <ø> (ø)
...ents/data-exploration/embedding/ClusterPopover.jsx 100.00% <ø> (ø)
src/components/data-management/NewProjectModal.jsx 73.80% <0.00%> (+3.35%) ⬆️
src/components/plots/PlotsTablesContainer.jsx 100.00% <ø> (ø)
...components/plots/styling/violin/ViolinControls.jsx 92.30% <ø> (ø)
...fferentialExpression/loadDifferentialExpression.js 88.88% <ø> (-2.29%) ⬇️
src/redux/actions/layout/addWindow.js 87.50% <ø> (-0.74%) ⬇️
src/redux/reducers/componentConfig/initialState.js 100.00% <ø> (ø)
src/utils/constants.js 100.00% <ø> (ø)
...ferentialExpression/getBackgroundExpressedGenes.js 100.00% <ø> (ø)
... and 39 more

... and 1 file with indirect coverage changes

@github-actions
Copy link
Contributor

📦 Next.js Bundle Analysis for ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 599.26 KB (🟡 +1.15 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

New Page Added

The following page was added to the bundle from the code in this PR:

Page Size (compressed) First Load
/experiments/[experimentId]/plots-and-tables/batch-differential-expression 80.56 KB 679.83 KB

Fifteen Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/data-management 252.3 KB (🟡 +711 B) 851.57 KB
/experiments/[experimentId]/data-exploration 615.89 KB (🟢 -3.26 KB) 1.19 MB
/experiments/[experimentId]/data-processing 562.44 KB (🟢 -172 B) 1.13 MB
/experiments/[experimentId]/plots-and-tables 15.45 KB (🟡 +76 B) 614.71 KB
/experiments/[experimentId]/plots-and-tables/dot-plot 574.15 KB (🟢 -1.06 KB) 1.15 MB
/experiments/[experimentId]/plots-and-tables/embedding-categorical 519.63 KB (🟢 -754 B) 1.09 MB
/experiments/[experimentId]/plots-and-tables/embedding-continuous 567.67 KB (🟢 -923 B) 1.14 MB
/experiments/[experimentId]/plots-and-tables/frequency 516.99 KB (🟢 -2.16 KB) 1.09 MB
/experiments/[experimentId]/plots-and-tables/marker-heatmap 671.3 KB (🟢 -3.62 KB) 1.24 MB
/experiments/[experimentId]/plots-and-tables/normalized-matrix 181.58 KB (🟢 -3.53 KB) 780.84 KB
/experiments/[experimentId]/plots-and-tables/trajectory-analysis 523.38 KB (🟢 -369 B) 1.1 MB
/experiments/[experimentId]/plots-and-tables/violin 597.22 KB (🟢 -520 B) 1.17 MB
/experiments/[experimentId]/plots-and-tables/volcano 524.17 KB (🟡 +46 B) 1.1 MB
/repository 103.26 KB (🟢 -85 B) 702.53 KB
/settings/profile 30.19 KB (🟡 +316 B) 629.45 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@github-actions
Copy link
Contributor

📦 Next.js Bundle Analysis for ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 599.26 KB (🟡 +1.15 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

New Page Added

The following page was added to the bundle from the code in this PR:

Page Size (compressed) First Load
/experiments/[experimentId]/plots-and-tables/batch-differential-expression 80.56 KB 679.83 KB

Fifteen Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/data-management 252.34 KB (🟡 +751 B) 851.6 KB
/experiments/[experimentId]/data-exploration 615.89 KB (🟢 -3.26 KB) 1.19 MB
/experiments/[experimentId]/data-processing 562.44 KB (🟢 -172 B) 1.13 MB
/experiments/[experimentId]/plots-and-tables 15.45 KB (🟡 +76 B) 614.71 KB
/experiments/[experimentId]/plots-and-tables/dot-plot 574.15 KB (🟢 -1.06 KB) 1.15 MB
/experiments/[experimentId]/plots-and-tables/embedding-categorical 519.63 KB (🟢 -754 B) 1.09 MB
/experiments/[experimentId]/plots-and-tables/embedding-continuous 567.67 KB (🟢 -923 B) 1.14 MB
/experiments/[experimentId]/plots-and-tables/frequency 516.99 KB (🟢 -2.16 KB) 1.09 MB
/experiments/[experimentId]/plots-and-tables/marker-heatmap 671.3 KB (🟢 -3.62 KB) 1.24 MB
/experiments/[experimentId]/plots-and-tables/normalized-matrix 181.58 KB (🟢 -3.53 KB) 780.84 KB
/experiments/[experimentId]/plots-and-tables/trajectory-analysis 523.38 KB (🟢 -369 B) 1.1 MB
/experiments/[experimentId]/plots-and-tables/violin 597.22 KB (🟢 -520 B) 1.17 MB
/experiments/[experimentId]/plots-and-tables/volcano 524.17 KB (🟡 +46 B) 1.1 MB
/repository 103.26 KB (🟢 -85 B) 702.53 KB
/settings/profile 30.19 KB (🟡 +316 B) 629.45 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@alexvpickering alexvpickering merged commit 384b13f into master May 30, 2023
@alexvpickering alexvpickering deleted the biomage-changes-4 branch May 30, 2023 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants