Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Violin plot #211

Merged
merged 18 commits into from
Apr 22, 2021
Merged

Support Violin plot #211

merged 18 commits into from
Apr 22, 2021

Conversation

xverges
Copy link
Contributor

@xverges xverges commented Apr 16, 2021

Background

Link to issue

https://biomage.atlassian.net/browse/BIOMAGE-472

Link to staging deployment URL

https://ui-xavier-ui211.scp-staging.biomage.net/experiments/e52b39624588791a7889e39c617f669e/plots-and-tables/violin

Links to any Pull Requests related to this

Anything else the reviewers should know about the changes here

Missing from the spec

  • ability to support raw values (only normalised available). This requires some work in the pipeline.
  • ability to show logarithmic vertical scale. Easy, but requires guidance on what to do with zeros.
  • ability to manage the x-axis labels

Changes

Code changes

Definition of DONE

Your changes will be ready for merging after each of the steps below have been completed:

Testing

  • Unit tests written
  • Tested locally with Inframock
  • Deployed to staging

To set up easy local testing with inframock, follow the instructions here: https://github.com/biomage-ltd/inframock
To deploy to the staging environment, follow the instructions here: https://github.com/biomage-ltd/biomage-utils

Documentation updates

Is all relevant documentation updated to reflect the proposed changes in this PR?

  • Relevant Github READMEs updated
  • Relevant wiki pages created/updated

Approvers

  • Approved by a member of the core engineering team
  • (UX changes) Approved by vickymorrison (this is her username, tag her if you need approval)

Just before merging:

Optional

  • Photo of a cute animal attached to this PR

@xverges xverges changed the title Draft - Support Violin plot Support Violin plot Apr 21, 2021
@xverges xverges merged commit 5cbaba6 into master Apr 22, 2021
@xverges xverges deleted the violin-plot branch April 22, 2021 19:32
alexvpickering pushed a commit that referenced this pull request May 15, 2023
[BIOMAGE-2405] - enable ribosomal genes filter checkbox
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants