Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes 4 #304

Merged
merged 88 commits into from
May 30, 2023
Merged

Changes 4 #304

merged 88 commits into from
May 30, 2023

Conversation

alexvpickering
Copy link
Contributor

@alexvpickering alexvpickering commented May 15, 2023

Description

Details

URL to issue

N/A

Link to staging deployment URL (or set N/A)

N/A

Links to any PRs or resources related to this PR

hms-dbmi-cellenics/ui#834
hms-dbmi-cellenics/api#433
hms-dbmi-cellenics/pipeline#302
#304

Integration test branch

master

Merge checklist

Your changes will be ready for merging after all of the steps below have been completed.

Code updates

Have best practices and ongoing refactors being observed in this PR

  • Migrated any selector / reducer used to the new format.

Manual/unit testing

  • Tested changes using InfraMock locally or no tests required for change, e.g. Kubernetes chart updates.
  • Validated that current unit tests for code work as expected and are sufficient for code coverage or no unit tests required for change, e.g. documentation update.
  • Unit tests written or no unit tests required for change, e.g. documentation update.

Integration testing

You must check the box below to run integration tests on the latest commit on your PR branch.
Integration tests have to pass before the PR can be merged. Without checking the box, your PR
will not pass the required status checks for merging.

  • Started end-to-end tests on the latest commit.

Documentation updates

  • Relevant Github READMEs updated or no GitHub README updates required.
  • Relevant Wiki pages created/updated or no Wiki updates required.

Optional

  • Staging environment is unstaged before merging.
  • Photo of a cute animal attached to this PR.

StefanBabukov and others added 23 commits April 27, 2023 12:00
change default prod timeout to 30 mins
[BIOMAGE-2347] - Update set output syntax
Reduce replica count in production to 1 for cost saving purposes
[BIOMAGE-1571] Add functionality to download a batched DE analysis table
Signed-off-by: Alex Pickering <[email protected]>
@codecov
Copy link

codecov bot commented May 15, 2023

Codecov Report

Merging #304 (2f15766) into master (48f4180) will increase coverage by 0.11%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #304      +/-   ##
==========================================
+ Coverage   98.26%   98.38%   +0.11%     
==========================================
  Files          21       22       +1     
  Lines         867      927      +60     
==========================================
+ Hits          852      912      +60     
  Misses         15       15              
Impacted Files Coverage Δ
r/R/cell_annotation_sctype.R 93.50% <100.00%> (+0.08%) ⬆️
r/R/download_annot_seurat_object.R 100.00% <100.00%> (ø)
r/R/utilities.R 100.00% <100.00%> (ø)

@alexvpickering alexvpickering merged commit 332ed4c into master May 30, 2023
@alexvpickering alexvpickering deleted the biomage-changes-4 branch May 30, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants