Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging changes #828

Merged
merged 207 commits into from
Mar 28, 2023
Merged

Merging changes #828

merged 207 commits into from
Mar 28, 2023

Conversation

alexvpickering
Copy link
Contributor

@alexvpickering alexvpickering commented Mar 14, 2023

Description

Details

URL to issue

N/A

Link to staging deployment URL (or set N/A)

N/A

Links to any PRs or resources related to this PR

hms-dbmi-cellenics/api#430
#828
hms-dbmi-cellenics/pipeline#300
hms-dbmi-cellenics/worker#300

Integration test branch

master

Merge checklist

Your changes will be ready for merging after all of the steps below have been completed.

Code updates

Have best practices and ongoing refactors being observed in this PR

  • Migrated any selector / reducer used to the new format.
  • All new dependency licenses have been checked for compatibility.

Manual/unit testing

  • Tested changes using InfraMock locally or no tests required for change, e.g. Kubernetes chart updates.
  • Validated that current unit tests for code work as expected and are sufficient for code coverage or no unit tests required for change, e.g. documentation update.
  • Unit tests written or no unit tests required for change, e.g. documentation update.

Integration testing

You must check the box below to run integration tests on the latest commit on your PR branch.
Integration tests have to pass before the PR can be merged. Without checking the box, your PR
will not pass the required status checks for merging.

  • Started end-to-end tests on the latest commit.

Documentation updates

  • Relevant Github READMEs updated or no GitHub README updates required.
  • Relevant Wiki pages created/updated or no Wiki updates required.

Optional

  • Staging environment is unstaged before merging.
  • Photo of a cute animal attached to this PR.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 14, 2023

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 598.11 KB (🟡 +832 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Eighteen Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/401 2.31 KB (🟢 -5 B) 600.42 KB
/404 2.32 KB (🟢 -8 B) 600.43 KB
/_error 2.7 KB (🟢 -336 B) 600.81 KB
/data-management 251.61 KB (🟢 -8.87 KB) 849.72 KB
/experiments/[experimentId]/data-exploration 619.15 KB (🟢 -13.11 KB) 1.19 MB
/experiments/[experimentId]/data-processing 562.6 KB (🟢 -17.41 KB) 1.13 MB
/experiments/[experimentId]/plots-and-tables 15.37 KB (🟢 -87 B) 613.49 KB
/experiments/[experimentId]/plots-and-tables/dot-plot 575.21 KB (🟢 -9.46 KB) 1.15 MB
/experiments/[experimentId]/plots-and-tables/embedding-categorical 520.37 KB (🟢 -10.02 KB) 1.09 MB
/experiments/[experimentId]/plots-and-tables/embedding-continuous 568.57 KB (🟢 -10.16 KB) 1.14 MB
/experiments/[experimentId]/plots-and-tables/frequency 519.15 KB (🟢 -10.12 KB) 1.09 MB
/experiments/[experimentId]/plots-and-tables/marker-heatmap 674.92 KB (🟢 -12.54 KB) 1.24 MB
/experiments/[experimentId]/plots-and-tables/normalized-matrix 185.11 KB (🟢 -6.53 KB) 783.22 KB
/experiments/[experimentId]/plots-and-tables/trajectory-analysis 523.74 KB (🟢 -13.39 KB) 1.1 MB
/experiments/[experimentId]/plots-and-tables/violin 597.73 KB (🟢 -10.37 KB) 1.17 MB
/experiments/[experimentId]/plots-and-tables/volcano 524.13 KB (🟢 -10.52 KB) 1.1 MB
/repository 103.35 KB (🟡 +5.09 KB) 701.46 KB
/settings/profile 29.88 KB (🟡 +1.08 KB) 627.99 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@codecov
Copy link

codecov bot commented Mar 18, 2023

Codecov Report

Merging #828 (5abe19a) into master (ab33aa5) will decrease coverage by 0.34%.
The diff coverage is 84.86%.

❗ Current head 5abe19a differs from pull request most recent head b72bcaf. Consider uploading reports for the commit b72bcaf to get more accurate results

@@            Coverage Diff             @@
##           master     #828      +/-   ##
==========================================
- Coverage   86.47%   86.13%   -0.34%     
==========================================
  Files         532      533       +1     
  Lines        9812     9811       -1     
  Branches     2013     2065      +52     
==========================================
- Hits         8485     8451      -34     
- Misses       1285     1316      +31     
- Partials       42       44       +2     
Impacted Files Coverage Δ
...omponents/data-exploration/embedding/CrossHair.jsx 88.88% <ø> (ø)
...xploration/generic-gene-table/SelectionActions.jsx 80.48% <ø> (ø)
...a-processing/DataIntegration/CalculationConfig.jsx 78.12% <ø> (ø)
src/components/plots/CategoricalEmbeddingPlot.jsx 95.12% <ø> (-0.12%) ⬇️
src/components/plots/ContinuousEmbeddingPlot.jsx 91.48% <ø> (-0.18%) ⬇️
src/components/plots/PlotsTablesContainer.jsx 100.00% <ø> (ø)
...nts/plots/helpers/heatmap/vega/generateVegaData.js 100.00% <ø> (ø)
.../plots/styling/embedding-continuous/SelectData.jsx 14.81% <0.00%> (ø)
src/config/defaultConfig.js 100.00% <ø> (ø)
src/config/testConfig.js 100.00% <ø> (ø)
... and 47 more

... and 6 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@alexvpickering alexvpickering merged commit fce95cf into master Mar 28, 2023
@alexvpickering alexvpickering deleted the biomage-changes-3 branch March 28, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants